This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Allow identifying black-flagged websites when fetching WPCom site info #3107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
force-pushed
the
issue/12775-connect-info-error-handling
branch
from
9d4aee8 to
3e83534
Compare
hichamboushaba
force-pushed
the
issue/12775-connect-info-error-handling
branch
from
3e83534 to
f51c7f6
Compare
4 tasks
JorgeMucientes
approved these changes
Oct 16, 2024
Contributor
JorgeMucientes
left a comment
JorgeMucientes
left a comment
There was a problem hiding this comment.
Nice work @hichamboushaba changes look good and work as expected! 
| hasJetpack, | ||
| isJetpackActive, | ||
| isJetpackConnected, | ||
| isWordPressDotCom, // CHECKSTYLE IGNORE |
Contributor
There was a problem hiding this comment.
TIL about this checkstyle rule: You should not use _dotcom_, use _wpcom_ instead
I wonder if it adds any value at all
Member
Author
There was a problem hiding this comment.
I'm not really sure, this code was just moved from below to be a local function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: woocommerce/woocommerce-android#12775
This PR updates the error parsing of the
/connect/site-infoendpoint handler to expose specific error type when the site is suspended (black-flagged).The PR also adds a coroutine based implementation of the
fetchConnectSiteInfofunction.Testing