Updates Dagger version to latest one. #85
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfano
approved these changes
Jan 28, 2025
Member
irfano
left a comment
irfano
left a comment
There was a problem hiding this comment.
Tested in woocommerce/woocommerce-android#13402. LGTM! 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Dagger version to
2.55.This update is needed to be able to upgrade Dagger version in client app of Media Picker. We found out that if Dagger is updated in the client app to a version above
2.51, but Media picker library doesn't update Dagger, then MediaPickerViewModel will crash when attempting to instantiate it. More context here.There's not much to be tested here. Only that all the checks pass. Going over the test instructions from this PR should be enough to ensure nothing is broken.