Media picker edge to edge support #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@atorresveiga Considering that this is a library, maybe adding proper edge-to-edge support right away here makes sense? I am talking about the bottom inset, which should be 0 and adding padding to the last item into the recycler view |
Contributor
Author
kidinov
reviewed
Mar 19, 2025
| insetsMask = WindowInsetsCompat.Type.navigationBars(), | ||
| consumeInsets = true | ||
| ) { insets -> | ||
| binding.recycler.addItemDecoration(LastItemPaddingDecoration(insets.bottom), 0) |
There was a problem hiding this comment.
@atorresveiga 👋
Would it do the same, just slightly simpler?
binding.recycler.clipToPadding = false
binding.recycler.updatePadding(bottom = insets.bottom)
kidinov
approved these changes
Mar 19, 2025
kidinov
left a comment
kidinov
left a comment
There was a problem hiding this comment.
LGTM!
I just left a suggestion how we maybe can do the same in a simpler way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some UI issues after updating to SDK 35 and the default edge-to-edge support. With the changes in this PR,
MediaPickerActivityconsumes insets and applies the needed padding to the screen.Testing
For testing this PR, it is better to use this Woo PR