Remove iOS 13 Widgets #19509

mokagio · 2022-10-25T05:46:00Z

Removes the iOS 13 widgets, WordPressTodayWidget, WordPressThisWeekWidget, and WordPressAllTimeWidget, plush does as little work as possible to get the app to build with iOS 14 as the minimum deployment target (#19496).

See also commit messages for additional details on the rationale behind some of the changes.

While working on this, I addressed a few more deprecations, see #19512, but I decided to keep them separated to focus this PR on widgets.

Regression Notes

Potential unintended areas of impact – N.A.
What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
What automated tests I added (or what prevented me from doing so) – N.A.

I have completed the Regression Notes.
I have considered adding unit tests for my changes. N.A.
I have considered adding accessibility improvements for my changes. N.A.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

mokagio · 2022-10-25T05:56:11Z

WordPress/Info.plist

-	<key>UIApplicationShortcutWidget</key>
-	<string>org.wordpress.WordPressTodayWidget</string>


As far as I could gather from the docs and the latest support page, this key was used at the time of the iOS 10 to 13 widgets but is no longer needed.

mokagio · 2022-10-25T06:01:28Z

WordPress/WordPress.xcodeproj/project.pbxproj

@@ -5593,13 +5461,10 @@
 		09C8BB8327DFF9CB00974175 /* ro */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ro; path = ro.lproj/InfoPlist.strings; sourceTree = "<group>"; };
 		09C8BB8427DFF9CC00974175 /* sk */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = sk; path = sk.lproj/InfoPlist.strings; sourceTree = "<group>"; };
 		09F367D2BE684EDE2E4A40E3 /* Pods-WordPressDraftActionExtension.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-WordPressDraftActionExtension.debug.xcconfig"; path = "../Pods/Target Support Files/Pods-WordPressDraftActionExtension/Pods-WordPressDraftActionExtension.debug.xcconfig"; sourceTree = "<group>"; };
-		0A27D496128FBCDFA3658994 /* Pods-WordPressHomeWidgetToday.release-internal.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-WordPressHomeWidgetToday.release-internal.xcconfig"; path = "../Pods/Target Support Files/Pods-WordPressHomeWidgetToday/Pods-WordPressHomeWidgetToday.release-internal.xcconfig"; sourceTree = "<group>"; };


Fun fact. We've been carrying around these WordPressHomeWidgetToday dead references ever since renaming that target to WordPressTodayWidget 😳

Thanks for noticing. The project will get a well-deserved clean-up then 👀

wpmobilebot · 2022-10-25T09:59:34Z

You can test the changes in Jetpack from this Pull Request by:

Clicking here or scanning the QR code below to access App Center
Then installing the build number pr19509-08f921a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

wpmobilebot · 2022-10-25T10:15:43Z

You can test the changes in WordPress from this Pull Request by:

Clicking here or scanning the QR code below to access App Center
Then installing the build number pr19509-08f921a on your iPhone

If you need access to App Center, please ask a maintainer to add you.

mokagio · 2022-10-25T12:39:02Z

cc @crazytonyli, if you have the time to take a look.

staskus

Thank you for the changes, @mokagio! I reviewed commit by commit. Additional changes unrelated to Widgets make sense as well. 👍

⚠️ Additional files that can be removed (In Today Widgets / Shared Views):

WidgetDiffferenceCell
WidgetTwoCollumnCell
WidgetUnconfiguredCell
WidgetUrlCell
WidgetNoConnectionCell

Potentially, there could be minor details related to iOS13 Widgets that could be removed as well, for example, some Constants and details saved to UserDefaults. However, iOS13 Widget data-loading code is reused by iOS14+ Widgets, therefore, it's hard to tell if any small details could be removed without negatively affecting current widgets. The majority of the code is removed in this PR.

⚠️ I see there're multiple places that still have #available(iOS 14.0, *), including Stats-related StatsWidgetStore. However, they could be removed in the parent PR or later.

I tested the app:

iOS 14 widgets continue working
Existing shortcuts continue working

peril-wordpress-mobile · 2022-10-27T04:11:25Z

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

mokagio · 2022-10-27T04:21:20Z

Thank you for the review @staskus 🙌

I removed the Shared Views that this work made unused as you suggested.

I see there're multiple places that still have #available(iOS 14.0, *), including Stats-related StatsWidgetStore. However, they could be removed in the parent PR or later.

Agreed. I might leave them for a PR later on. As a matter of fact, I already removed them here but I think I'll submit them in isolation after #19496 lands.

staskus

@mokagio, I don't see SharedViews being removed.

staskus

I don't want to block this PR, so after shared views are removed, we can move on. 👍

mokagio · 2022-10-27T23:33:53Z

@mokagio, I don't see SharedViews being removed.

I didn't push them... 😓 But you can see them in the timeline now

Thank you for the approval to unblock. I'll merge as soon as CI is green.

staskus · 2022-10-28T06:36:19Z

I see the changes now, all good 🚀

guarani

Apologies for the late review, @mokagio. The code changes look right and I gave the Jetpack app and the WP app both a quick smoke test (adding Home Screen widgets, scheduling a post, etc.) – all good.

I love how this reduced the number of targets in the project ❤️ Thanks for wrangling this!

Are you planning to merge this in 21.1 or bump to the next version?

This way, all the targets will use the same iOS deployment, all coming from the project-level setting.

The class property was deprecated in iOS 14. Xcode gave the following warning (which we treat as an error): > Deprecated. Use the instance property `authorizationStatus` instead.

The deprecation warning in Xcode wasn't informative, but the deprecation annotation suggested what to do: ``` /* * locationManager:didChangeAuthorizationStatus: * * Discussion: * Invoked when the authorization status changes for this application. */ - (void)locationManager:(CLLocationManager *)manager didChangeAuthorizationStatus:(CLAuthorizationStatus)status API_DEPRECATED_WITH_REPLACEMENT("-locationManagerDidChangeAuthorization:", ios(4.2, 14.0), macos(10.7, 11.0), watchos(1.0, 7.0), tvos(9.0, 14.0)); ```

This legacy widget extension has been superseded by `WordPressStatsWidgets`.

These were there to be ready to use once the team was ready to add the widgets. In the meantime, we decided to drop iOS 13, which removes the need for them.

This would have been the name of the very first iOS 10 home widget we added. Since then, it was renamed but we missed the dead references.

mokagio self-assigned this Oct 25, 2022

mokagio changed the base branch from trunk to drop-ios-13 October 25, 2022 05:54

mokagio commented Oct 25, 2022

View reviewed changes

mokagio force-pushed the mokagio/remove-ios-13-widgets branch 3 times, most recently from 089ffab to 46b53ec Compare October 25, 2022 12:04

mokagio added this to the 21.1 milestone Oct 25, 2022

mokagio requested a review from guarani October 25, 2022 12:24

mokagio marked this pull request as ready for review October 25, 2022 12:38

mokagio requested a review from staskus October 25, 2022 12:38

mokagio mentioned this pull request Oct 25, 2022

Bump iOS deployment target from 13.0 to 14.0 #19496

Closed

4 tasks

staskus reviewed Oct 26, 2022

View reviewed changes

mokagio force-pushed the drop-ios-13 branch from fc0853d to 30f02ee Compare October 27, 2022 01:58

mokagio force-pushed the mokagio/remove-ios-13-widgets branch from 46b53ec to fc4d3b8 Compare October 27, 2022 04:11

mokagio requested a review from staskus October 27, 2022 04:17

staskus reviewed Oct 27, 2022

View reviewed changes

staskus self-requested a review October 27, 2022 07:07

staskus approved these changes Oct 27, 2022

View reviewed changes

mokagio force-pushed the drop-ios-13 branch from 193b8b5 to c13ed67 Compare October 28, 2022 02:40

guarani approved these changes Oct 28, 2022

View reviewed changes

mokagio changed the base branch from drop-ios-13 to trunk October 31, 2022 01:25

Remove target-level IPHONEOS_DEPLOYMENT_TARGET setting

96ac83a

This way, all the targets will use the same iOS deployment, all coming from the project-level setting.

mokagio and others added 17 commits October 31, 2022 12:28

Extract IPHONEOS_DEPLOYMENT_TARGET to SDKVersions.xcconfig

8c34b62

Bump IPHONEOS_DEPLOYMENT_TARGET from 13.0 to 14.0

9f58825

Add RELEASE-NOTES.txt entry for dropping iOS 13

357e080

Use CLLocationManager instance property for authorizationStatus

04a9a44

The class property was deprecated in iOS 14. Xcode gave the following warning (which we treat as an error): > Deprecated. Use the instance property `authorizationStatus` instead.

Remove iOS 13 only SchedulingCalendarViewController

a60d3d9

Remove WordPressTodayWidget in preparation to drop iOS 13

1ba9de3

This legacy widget extension has been superseded by `WordPressStatsWidgets`.

Remove WordPressAllTimeWidget in preparation to drop iOS 13

81d2e71

This legacy widget extension has been superseded by `WordPressStatsWidgets`.

Remove WordPressThisWeekWidget in preparation to drop iOS 13

76435ca

This legacy widget extension has been superseded by `WordPressStatsWidgets`.

Remove bundle identifiers for iOS 13 widgets in Jetpack from Fastfile

a6c25c8

These were there to be ready to use once the team was ready to add the widgets. In the meantime, we decided to drop iOS 13, which removes the need for them.

Remove leftover references to old WordPressHomeWidgetToday

f713bf9

This would have been the name of the very first iOS 10 home widget we added. Since then, it was renamed but we missed the dead references.

Remove WidgetDifferenceCell — It was used only in the iOS 13 widgets

658cedf

Remove WidgetTwoColumnCell — It was used only in the iOS 13 widgets

ced1dd3

Remove WidgetUnconfiguredCell — It was used only in the iOS 13 widgets

a8e019d

Remove WidgetUrlCell — It was used only in the iOS 13 widgets

02f7361

Remove WidgetNoConnectionCell — It was used only in the iOS 13 widgets

46ee6b0

Remove empty Shared View group for widgets

d6392db

mokagio force-pushed the mokagio/remove-ios-13-widgets branch from 0956955 to d6392db Compare October 31, 2022 01:44

mokagio enabled auto-merge October 31, 2022 01:46

Update RELEASE-NOTES.txt to mention new PR for dropping iOS 13

08f921a

mokagio merged commit 0405eb4 into trunk Oct 31, 2022

mokagio deleted the mokagio/remove-ios-13-widgets branch October 31, 2022 02:34

mokagio mentioned this pull request Dec 2, 2022

Remove unnecessary SchedulingViewControllerProtocol #19708

Merged

4 tasks

staskus mentioned this pull request Sep 7, 2023

Remove WordPress widget and iOS 13 Today widget related code #21521

Merged

4 tasks

		<key>UIApplicationShortcutWidget</key>
		<string>org.wordpress.WordPressTodayWidget</string>

Remove iOS 13 Widgets #19509

Remove iOS 13 Widgets #19509

Uh oh!

Conversation

mokagio commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Regression Notes

Uh oh!

mokagio Oct 25, 2022

Choose a reason for hiding this comment

Uh oh!

mokagio Oct 25, 2022

Choose a reason for hiding this comment

Uh oh!

staskus Oct 25, 2022

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Oct 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mokagio commented Oct 25, 2022

Uh oh!

staskus left a comment

Choose a reason for hiding this comment

Uh oh!

peril-wordpress-mobile bot commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mokagio commented Oct 27, 2022

Uh oh!

staskus left a comment

Choose a reason for hiding this comment

Uh oh!

staskus left a comment

Choose a reason for hiding this comment

Uh oh!

mokagio commented Oct 27, 2022

Uh oh!

staskus commented Oct 28, 2022

Uh oh!

guarani left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mokagio commented Oct 25, 2022 •

edited

Loading

wpmobilebot commented Oct 25, 2022 •

edited

Loading

wpmobilebot commented Oct 25, 2022 •

edited

Loading

peril-wordpress-mobile bot commented Oct 27, 2022 •

edited

Loading