Skip to content

Conversation

@crazytonyli
Copy link
Contributor

Changes

ContextManagerMock was created solely to workaround the deadlock issue mentioned in the saveContextAndWait override. Now that we've switched over to NSPersistentContainer(still needs to wait to see if it will introduce any issue in versions 21.1), we no longer need this "mock implementation". This PR deletes it and prepares for the follow up PR, which is deleting the legacy code and completing the NSPersistentContainer migration.

  • This PR can be merged if NSPersistentContainer doesn't introduce major issue in v21.1.

Test instructions

All good if CI jobs pass.

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    None.

  3. What automated tests I added (or what prevented me from doing so)
    None.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@crazytonyli crazytonyli added [Status] DO NOT MERGE Core Data Issues related to Core Data labels Nov 14, 2022
@crazytonyli crazytonyli added this to the 21.3 milestone Nov 14, 2022
@crazytonyli crazytonyli requested a review from mokagio November 14, 2022 08:11
@crazytonyli crazytonyli self-assigned this Nov 14, 2022
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19588-8136321 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19588-8136321 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge once the preconditions have been validated 👍

@crazytonyli crazytonyli modified the milestones: 21.3, 21.4 Nov 28, 2022
@crazytonyli crazytonyli merged commit b0f22e0 into trunk Dec 12, 2022
@crazytonyli crazytonyli deleted the refactor-context-manager-mock branch December 12, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Data Issues related to Core Data

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants