Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ContextManagerMockwas created solely to workaround the deadlock issue mentioned in thesaveContextAndWaitoverride. Now that we've switched over toNSPersistentContainer(still needs to wait to see if it will introduce any issue in versions 21.1), we no longer need this "mock implementation". This PR deletes it and prepares for the follow up PR, which is deleting the legacy code and completing theNSPersistentContainermigration.NSPersistentContainerdoesn't introduce major issue in v21.1.Test instructions
All good if CI jobs pass.
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.