Remove CocoaLumberjack from the libraries #19643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpmobilebot
reviewed
Nov 23, 2022
Podfile
Outdated
| # pod 'WordPressShared', '~> 1.18.0' | ||
| # pod 'WordPressShared', :git => 'https://github.com/wordpress-mobile/WordPress-iOS-Shared.git', :tag => '' | ||
| # pod 'WordPressShared', :git => 'https://github.com/wordpress-mobile/WordPress-iOS-Shared.git', :branch => '' | ||
| pod 'WordPressShared', :git => 'https://github.com/wordpress-mobile/WordPress-iOS-Shared.git', :branch => 'delete-cocoalumberjack' |
Contributor
There was a problem hiding this comment.
| 🚫 | Use the new Ruby 1.9 hash syntax. |
crazytonyli
force-pushed
the
wpshared-remove-cocoalumberjack
branch
4 times, most recently
from
989310a to
e68fba7
Compare
Contributor
You can test the changes in WordPress from this Pull Request by:
|
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
crazytonyli
force-pushed
the
wpshared-remove-cocoalumberjack
branch
from
e68fba7 to
72d30c7
Compare
crazytonyli
changed the title
crazytonyli
force-pushed
the
wpshared-remove-cocoalumberjack
branch
from
72d30c7 to
2e66cbf
Compare
crazytonyli
force-pushed
the
wpshared-remove-cocoalumberjack
branch
from
2e66cbf to
ee2fe1d
Compare
mokagio
approved these changes
Jan 9, 2023
Generated by 🚫 dangerJS |
Contributor
|
@crazytonyli I took over this branch to fix the merge conflict and merge it into |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Library updates
Here are full change sets in the libraries:
Unfortunately the CHANGELOG file doesn't contain all the releases. But by looking at the diff, WordPressShared and WordPressKit updates seems simply and straight forward to me. The WordPressAuthenticator update brings in some feature changes, which seems are all additive changes according to its changelog.
Logging in the libraries
This is the main reason I created this PR.
WordPressShared, WordPressKit, and WordPressAuthenticator used to depend on CocoaLumberjack and have their own
ddLogLevelvariable. It's strange that compiler would allow this, but this approach feels problematic anyway.The new version of these libraries now have a function to set a logger instance, which uses the CocoaLumberjack set up in the app. Thus they no longer depend on CocoaLumberjack and also makes changing log level easier—there is only one log level variable which is in the app.
I've also updated the CocoaLumberjack Swift logging functions implementation in the app, using built-in functions in the latest version rather than using a copy of these functions in our own codebase.
Test instructions
Not entirely what to test. Maybe make sure log in and log out work as expected (which I've checked)?
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
None.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.