Address a couple of warnings. #19746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`guard` is better for early return because the compiler enforces calling `return`.
Generated by 🚫 dangerJS |
mokagio
commented
Dec 6, 2022
| static func getTags() -> [String] { | ||
|
|
||
| let context = ContextManager.sharedInstance().mainContext | ||
| let blogService = BlogService(managedObjectContext: context) |
Contributor
Author
There was a problem hiding this comment.
@crazytonyli I think this was a leftover from the various iterations on the API used to fetch resources, right?
I checked the implementation and couldn't find a reason to init the service without using it. But I might have missed something...
Contributor
There was a problem hiding this comment.
Yeah, it must be, but should be safe to remove though. Thanks!
mokagio
commented
Dec 6, 2022
| let currentLightIcons = allIcons.filter({ $0.isLegacy == false && $0.isBordered == true }) | ||
| .sorted(by: sortWithPriority(toItemsWithPrefix: AppIcon.defaultIconName)) | ||
| let legacyIcons = { | ||
| var icons = allIcons.filter({ $0.isLegacy == true }) |
Contributor
Author
There was a problem hiding this comment.
The warning itself was on this being a var that was never mutated. While I was at it, I also adopted guard for the early-return.
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
crazytonyli
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of easy wins I noticed. See code for more details...
Regression Notes
RELEASE-NOTES.txtif necessary. N.A.