-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fixes a couple of flaky unit and UI tests #19750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 dangerJS |
You can test the changes in WordPress from this Pull Request by:
|
You can test the changes in Jetpack from this Pull Request by:
|
jostnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at making UI tests more reliable @hassaanelgarem ! I'm not too sure which tests this is looking to fix exactly but from the list here and the changes made, I'm thinking it's testAddGalleryBlock but please let me know if that's not it.
I have one comment but other than that it should be good!
WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift
Outdated
Show resolved
Hide resolved
@jostnes Yeah sorry about that. You're correct. I've updated the PR description with the targeted tests 👍 |
…wift Co-authored-by: Jos <[email protected]>
jostnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the description, the test looks good! ![]()
Description
This PR fixes a couple of flaky unit and UI tests.
Tests targeted are the least reliable tests based on Buildkite's test analytics.
Targeted tests:
MediaURLExporterTests.testThatURLExportingVideoWorksMediaURLExporterTests.testThatURLExportingVideoWithoutGPSWorksEditorGutenbergTests.testAddGalleryBlockTesting Instructions
No need for testing. If the CI passes, then we're good to go
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.