Skip to content

Remove self-hosted credentials from keychain when the site is removed #19756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Remove self-hosted credentials from keychain when the site is removed #19756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions WordPress/Classes/Models/Blog.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,11 @@ - (void)prepareForDeletion
{
[super prepareForDeletion];

// delete stored password in the keychain for self-hosted sites.
if ([self.username length] > 0 && [self.xmlrpc length] > 0) {
self.password = nil;
}

[_xmlrpcApi invalidateAndCancelTasks];
[_wordPressOrgRestApi invalidateAndCancelTasks];
}
Expand Down