Skip to content

[Jetpack Focus] Reenable Jetpack Notifications Disabling Feature Flag and Release Notes #19761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2022
Merged

[Jetpack Focus] Reenable Jetpack Notifications Disabling Feature Flag and Release Notes #19761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ff9f76
Update RELEASE-NOTES.txt
staskus Dec 9, 2022
2b3e7a0
Reenable usage of remote feature flags
staskus Dec 9, 2022
1356f97
Reenable local feature flag
staskus Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
-----
* [*] Share extension navigation bar is no longer transparent [#19700]
* [**] [internal] Upgrade React Native from 0.66.2 to 0.69.4 [https://github.com/wordpress-mobile/gutenberg-mobile/pull/5193]
* [*] [internal] When a user migrates to the Jetpack app and allows notifications, WordPress app notifications are disabled. [#19616, #19611, #19590]

21.3
-----
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Services/JetpackNotificationMigrationService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class JetpackNotificationMigrationService: JetpackNotificationMigrationSer
private let jetpackNotificationMigrationDefaultsKey = "jetpackNotificationMigrationDefaultsKey"

private var jetpackMigrationPreventDuplicateNotifications: Bool {
return FeatureFlag.jetpackMigrationPreventDuplicateNotifications.enabled
return featureFlagStore.value(for: FeatureFlag.jetpackMigrationPreventDuplicateNotifications)
}

private var notificationSettingsService: NotificationSettingsService?
Expand Down
2 changes: 1 addition & 1 deletion WordPress/Classes/Utility/BuildInformation/FeatureFlag.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ enum FeatureFlag: Int, CaseIterable, OverrideableFlag {
case .newCoreDataContext:
return true
case .jetpackMigrationPreventDuplicateNotifications:
return false
return true
case .jetpackFeaturesRemovalPhaseOne:
return false
case .jetpackFeaturesRemovalPhaseTwo:
Expand Down