-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix crash when perform is called on a context with deprecated concurrency type
#19765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+129
−6
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
WordPress/WordPressTest/ContainerContextFactoryTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| import XCTest | ||
|
|
||
| @testable import WordPress | ||
|
|
||
| final class ContainerContextFactoryTests: XCTestCase { | ||
|
|
||
| private var persistentContainer: NSPersistentContainer! | ||
| private var factory: ContainerContextFactory! | ||
|
|
||
| override func setUp() { | ||
| super.setUp() | ||
|
|
||
| persistentContainer = makeInMemoryContainer() | ||
| factory = ContainerContextFactory(persistentContainer: persistentContainer) | ||
| } | ||
|
|
||
| override func tearDown() { | ||
| persistentContainer = nil | ||
| factory = nil | ||
|
|
||
| super.tearDown() | ||
| } | ||
|
|
||
| // MARK: - `save` Tests | ||
|
|
||
| func test_save_givenMainQueueConcurrencyType_shouldCallPerform() { | ||
| let context = makeMockContext(concurrencyType: .mainQueueConcurrencyType) | ||
|
|
||
| factory.save(context, andWait: false, withCompletionBlock: nil) | ||
|
|
||
| XCTAssertTrue(context.performCalled) | ||
| XCTAssertFalse(context.performAndWaitCalled) | ||
| } | ||
|
|
||
| func test_save_givenMainQueueConcurrencyType_andWaitIsSetToTrue_shouldCallPerformAndWait() { | ||
| let context = makeMockContext(concurrencyType: .mainQueueConcurrencyType) | ||
|
|
||
| factory.save(context, andWait: true, withCompletionBlock: nil) | ||
|
|
||
| XCTAssertFalse(context.performCalled) | ||
| XCTAssertTrue(context.performAndWaitCalled) | ||
| } | ||
|
|
||
| func test_save_givenPrivateQueueConcurrencyType_shouldCallPerform() { | ||
| let context = makeMockContext(concurrencyType: .privateQueueConcurrencyType) | ||
|
|
||
| factory.save(context, andWait: false, withCompletionBlock: nil) | ||
|
|
||
| XCTAssertTrue(context.performCalled) | ||
| XCTAssertFalse(context.performAndWaitCalled) | ||
| } | ||
|
|
||
| func test_save_givenPrivateQueueConcurrencyType_andWaitIsSetToTrue_shouldCallPerformAndWait() { | ||
| let context = makeMockContext(concurrencyType: .privateQueueConcurrencyType) | ||
|
|
||
| factory.save(context, andWait: true, withCompletionBlock: nil) | ||
|
|
||
| XCTAssertFalse(context.performCalled) | ||
| XCTAssertTrue(context.performAndWaitCalled) | ||
| } | ||
|
|
||
| func test_save_givenDeprecatedConcurrencyType_shouldNotCallPerform() { | ||
| /// creates a context with `.confinementConcurrencyType`. The enum is created from its raw value | ||
| /// to prevent Xcode from complaining since the enum value is deprecated. | ||
| let context = makeMockContext(concurrencyType: NSManagedObjectContextConcurrencyType(rawValue: 0)!) | ||
|
|
||
| factory.save(context, andWait: false, withCompletionBlock: nil) | ||
|
|
||
| XCTAssertFalse(context.performCalled) | ||
| XCTAssertFalse(context.performAndWaitCalled) | ||
| } | ||
| } | ||
|
|
||
| // MARK: - Private Helpers | ||
|
|
||
| private extension ContainerContextFactoryTests { | ||
|
|
||
| class MockManagedObjectContext: NSManagedObjectContext { | ||
|
|
||
| var performCalled = false | ||
| var performAndWaitCalled = false | ||
|
|
||
| override func perform(_ block: @escaping () -> Void) { | ||
| performCalled = true | ||
| } | ||
|
|
||
| override func performAndWait(_ block: () -> Void) { | ||
| performAndWaitCalled = true | ||
| } | ||
|
|
||
| override func save() throws { | ||
| // do nothing. let's make sure nothing gets saved. | ||
| } | ||
| } | ||
|
|
||
| /// Creates an "in-memory" NSPersistentContainer. | ||
| /// This follows the approach used in WWDC'18: https://developer.apple.com/videos/play/wwdc2018/224/ | ||
| /// | ||
| /// - Returns: An instance of NSPersistentContainer that stores data in memory. | ||
| func makeInMemoryContainer() -> NSPersistentContainer { | ||
| let container = NSPersistentContainer(name: "WordPress") | ||
| let description = NSPersistentStoreDescription(url: .init(fileURLWithPath: "/dev/null")) | ||
| container.persistentStoreDescriptions = [description] | ||
|
|
||
| return container | ||
| } | ||
|
|
||
| func makeMockContext(concurrencyType: NSManagedObjectContextConcurrencyType) -> MockManagedObjectContext { | ||
| return MockManagedObjectContext(concurrencyType: concurrencyType) | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do
if context.concurrencyType == .confinementConcurrencyType {, but Xcode will throw out a warning if we type a deprecated enum value. 🙃