Skip to content

Conversation

@sla8c
Copy link
Contributor

@sla8c sla8c commented Dec 12, 2022

This PR adds functionality to bring iOS app + followers details screens to parity with Android.

I reviewed the original stats revamp designs from the designer and I had made an assumption about what Followers details should be as the stats revamp design(s) did not have any information on what should be done on the followers card. As a result, I've implemented a change so that iOS has parity with Android

Fixes #19763

To test:

  1. Enable new stats feature flags
  2. Go to Stats screen -> Insights
  3. Tap Total Followers. You should be navigated to the Total Followers screen

image

  1. Navigate back to Insights main screen
  2. Go to the Followers card and tap "View more". You should be navigated to the following screen

image

Regression Notes

  1. Potential unintended areas of impact
    Stats revamp

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested

  3. What automated tests I added (or what prevented me from doing so)
    N/A
    PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@sla8c sla8c added this to the 21.5 milestone Dec 12, 2022
@sla8c sla8c requested a review from staskus December 12, 2022 17:35
@sla8c sla8c self-assigned this Dec 12, 2022
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19768-7bb2539 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19768-7bb2539 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@staskus
Copy link
Contributor

staskus commented Dec 13, 2022

👍 Changes look good and I can verify that clicking "Followers" and "Total Followers" opens appropriate views. ✅

However, switching between "WordPress.com / Email" tabs is broken to me in the follower's view. Are you able to reproduce it? I'm not sure if it's related to this PR and the way the view is presented.

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. Button hit area issue could be addressed in another issue.

@sla8c
Copy link
Contributor Author

sla8c commented Dec 13, 2022

👍 Changes look good and I can verify that clicking "Followers" and "Total Followers" opens appropriate views. ✅

However, switching between "WordPress.com / Email" tabs is broken to me in the follower's view. Are you able to reproduce it? I'm not sure if it's related to this PR and the way the view is presented.

Thanks I will take a look at the hit area issue + create a new issue if I find something. Thanks for reviewing! 🙇

@sla8c sla8c merged commit 88ebfc6 into trunk Dec 13, 2022
@sla8c sla8c deleted the issue/stats-revamp-followersdetails-datepicker branch December 13, 2022 10:03
@sla8c sla8c modified the milestones: 21.5, 21.4 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] Stats: Remove Date Picker from Insights -> Followers details view

5 participants