Skip to content

Conversation

@dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Dec 13, 2022

Description

As titled, this fixes an issue where the background color for the filter tab in Notifications appears as if it's "leaking" to the table view side. See the below image for example:

iphone_before_dark

The "leaked" space was an incidental bug from #16962, where we added some padding between the filter tab bar and the first table view header. It was a design decision to give some space between the two elements, so they don't feel too cramped visually — especially when the table header is already pretty compact.

Here's how it looks before and after the change in various configurations:

Scenarios Before After
iPhone, Dark iphone_before_dark iphone_after_dark
iPad, Dark ipad_before_dark ipad_after_dark
iPhone, Light iphone_before_light iphone_after_light
iPad, Light ipad_before_light ipad_after_light

To test

  • Open either WordPress or Jetpack app.
  • Switch to dark scheme.
  • Go to the Notifications tab.
  • 🔍 Verify that the filter tab bar's background color is no longer leaking.

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the changes.

  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dvdchr dvdchr added this to the 21.5 milestone Dec 13, 2022
@dvdchr dvdchr self-assigned this Dec 13, 2022
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19772-1ab92df on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19772-1ab92df on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@dvdchr dvdchr requested review from alpavanoglu and wargcm December 14, 2022 09:34
Copy link
Contributor

@alpavanoglu alpavanoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is confirmed in trunk, resolved here ✅

@dvdchr dvdchr modified the milestones: 21.5, 21.4 Dec 14, 2022
@dvdchr
Copy link
Contributor Author

dvdchr commented Dec 14, 2022

Thanks @alpavanoglu!

@dvdchr dvdchr merged commit 20b73e5 into trunk Dec 14, 2022
@dvdchr dvdchr deleted the feature/notifications-header-bg branch December 14, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants