Notifications: Fix filter tab color "leaking" to table view in dark scheme #19772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As titled, this fixes an issue where the background color for the filter tab in Notifications appears as if it's "leaking" to the table view side. See the below image for example:
The "leaked" space was an incidental bug from #16962, where we added some padding between the filter tab bar and the first table view header. It was a design decision to give some space between the two elements, so they don't feel too cramped visually — especially when the table header is already pretty compact.
Here's how it looks before and after the change in various configurations:
To test
Regression Notes
Potential unintended areas of impact
Should be none.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the changes.
What automated tests I added (or what prevented me from doing so)
N/A.
PR submission checklist:
RELEASE-NOTES.txtif necessary.