Skip to content

Conversation

@hassaanelgarem
Copy link
Contributor

Closes #19451

Description

This PR displays the feature collection overlay for phase 3. The overlay is displayed upon opening the app. It is the same overlay that's displayed when tapping the menu card. It should be displayed only once during phase 3.

The PR also has a small tweak to the menu card c4376c6 that was found during development.

Screenshots

Light Mode Dark Mode
light dark

Testing Instructions

  1. Open the app
  2. Make sure that none of the Jetpack removal flags are enabled from the debug menu
  3. Navigate to My Site
  4. Close and re-open the app
  5. Make sure the overlay is not displayed
  6. Make sure that only the "Jetpack Features Removal Phase Three" flag is enabled from the debug menu
  7. Navigate to My Site
  8. Close and re-open the app
  9. Make sure the overlay is displayed with the correct content and matches the design
  10. Close and re-open the app
  11. Make sure the overlay is not displayed again

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 20, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19795-f19d60f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 20, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19795-f19d60f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hassaanelgarem hassaanelgarem merged commit 4e71748 into trunk Dec 20, 2022
@hassaanelgarem hassaanelgarem deleted the task/19451-phase-three-overlays branch December 20, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jetpack Focus: Display Jetpack feature collection overlays on app open

4 participants