Fix WordPressKit API breaking changes

[salimbraksa]

Related PR

The following PR in WordPressKit should be merged first to trigger a pod update.

• Bump pod version to 5.0.1-beta.1 WordPressKit-iOS#566

Description

This PR fixes a build error due to WordPressKit API breaking changes. During the rewrite of RemoteReaderSiteInfo from Objective-C to Swift, the postSubscription and emailSubscription properties are now optional. This PR handles the nullability of those properties.

How to Reproduce

1. Switch to wpshared-remove-cocoalumberjack branch
2. Open the Podfile
3. Install latest WordPressKit changes

def wordpress_kit
  # pod 'WordPressKit', '~> 5.0'
  # pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :tag => ''
  pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => 'trunk'
  # pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :commit => ''
  # pod 'WordPressKit', :path => '../WordPressKit-iOS'
end

3. Open Xcode and try building the app
4. Expect the build to fail

Test Instructions:

1. Switch back to this branch
2. Install latest WordPressKit changes

def wordpress_kit
  # pod 'WordPressKit', '~> 5.0'
  # pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :tag => ''
  pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => 'trunk'
  # pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :commit => ''
  # pod 'WordPressKit', :path => '../WordPressKit-iOS'
end

3. Open Xcode and build the app
4. Expect the build to succeed

Regression Notes

1. Potential unintended areas of impact
   None.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   None.

3. What automated tests I added (or what prevented me from doing so)
   None.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19802-5eef2c7 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19802-5eef2c7 on your iPhone

If you need access to App Center, please ask a maintainer to add you.