Skip to content

Conversation

@hassaanelgarem
Copy link
Contributor

@hassaanelgarem hassaanelgarem commented Dec 28, 2022

Part of #19810

Description

This PR partially removes the jetpack features for users in P4. It removes the tab bar and removes the visible entry points for Jetpack features.

This PR also disables Quick Start and the onboarding prompt for the simplified UI. It also removed the outdated My Site Dashboard feature flag.

⚠️ Disclaimer ⚠️

In the simplified UI, we no longer display a WPTabBarController. However, many areas of the app depend on WPTabBarController.sharedInstance to perform some actions. And for that, the simplified UI at this point has some known issues. One issue, for example, is that the Floating Button actions are not working.

These issues will be addressed in a following PR that removes all the dependencies on WPTabBarController.sharedInstance.

Screenshots

iPhone iPad
iPhone iPad

Testing Instructions

  1. Run the app
  2. Open the debug menu and disable all the Jetpack Features Removal flags
  3. Kill the app
  4. Relaunch the app
  5. Make sure the app is behaving normally
  6. Open the debug menu and enable "Jetpack Features Removal Phase Four"
  7. Kill the app
  8. Relaunch the app
  9. Make sure the tap bar is gone and all Jetpack features are removed.

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 28, 2022

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19816-c0ad158 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 28, 2022

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19816-c0ad158 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@hassaanelgarem hassaanelgarem marked this pull request as ready for review December 29, 2022 02:09
@staskus staskus self-requested a review December 29, 2022 09:57
Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving couple of comments, so far functionality worked as expected 👍

Moving on to check another PR since they are related.

@dvdchr dvdchr self-requested a review December 30, 2022 07:55
Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this looks good to me. I performed the testing steps on the iPad, and it works as described.

I'll check the second PR and verify that the floating button works.

# Conflicts:
#	WordPress/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackFeaturesRemovalCoordinator.swift
@hassaanelgarem hassaanelgarem changed the title Jetpack Focus: Implement simplified UI Jetpack Focus: Remove Jetpack features during phase 4 Jan 1, 2023
@hassaanelgarem hassaanelgarem merged commit 7b7fcb6 into trunk Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants