-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Jetpack Focus: Remove Jetpack features during phase 4 #19816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
staskus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving couple of comments, so far functionality worked as expected 👍
Moving on to check another PR since they are related.
...ess/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackFeaturesRemovalCoordinator.swift
Show resolved
Hide resolved
...ess/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackFeaturesRemovalCoordinator.swift
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController.m
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Blog/Blog Details/BlogDetailsViewController+SectionHelpers.swift
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/System/Coordinators/MySitesCoordinator.swift
Show resolved
Hide resolved
...ess/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackFeaturesRemovalCoordinator.swift
Show resolved
Hide resolved
dvdchr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this looks good to me. I performed the testing steps on the iPad, and it works as described.
I'll check the second PR and verify that the floating button works.
WordPress/Classes/ViewRelated/System/Coordinators/MySitesCoordinator.swift
Show resolved
Hide resolved
# Conflicts: # WordPress/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackFeaturesRemovalCoordinator.swift
Part of #19810
Description
This PR partially removes the jetpack features for users in P4. It removes the tab bar and removes the visible entry points for Jetpack features.
This PR also disables Quick Start and the onboarding prompt for the simplified UI. It also removed the outdated My Site Dashboard feature flag.
In the simplified UI, we no longer display a WPTabBarController. However, many areas of the app depend on
WPTabBarController.sharedInstanceto perform some actions. And for that, the simplified UI at this point has some known issues. One issue, for example, is that the Floating Button actions are not working.These issues will be addressed in a following PR that removes all the dependencies on
WPTabBarController.sharedInstance.Screenshots
Testing Instructions
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.