Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
43f6e46
Update: replace Reader-related WPTabBarController.sharedInstance usages
hassaanelgarem Dec 27, 2022
5866206
Refactor: MeNavigation as an extension on RootViewPresenter for reusa…
hassaanelgarem Dec 27, 2022
0dfbf89
Fix: remove white spaces
hassaanelgarem Dec 27, 2022
9a66698
Update: replace Search-related WPTabBarController.sharedInstance usages
hassaanelgarem Dec 27, 2022
ca886bb
Update: replace usages of `showNotificationsTab`
hassaanelgarem Dec 27, 2022
493a27f
Update: replace usage of `showReaderTab(forPost:)`
hassaanelgarem Dec 27, 2022
14fa3a5
Update: replace usages of `WPTabBarController.sharedInstance` in Me n…
hassaanelgarem Dec 27, 2022
831de53
Update: replace usage of `showMedia(for:)`
hassaanelgarem Dec 27, 2022
3e38635
Update: replace usage of `showPosts(for:)`
hassaanelgarem Dec 27, 2022
1882ea1
Update: replace usages of `present()` and `dismiss()`
hassaanelgarem Dec 27, 2022
8bab975
Update: replace usages of `WPTabBarController.sharedInstance()` in `P…
hassaanelgarem Dec 27, 2022
8fbfd1b
Update: replace usages of `currentlySelectedScreen()`
hassaanelgarem Dec 27, 2022
cd976e8
Update: replace usages of `showBlogDetails()`
hassaanelgarem Dec 27, 2022
19f48de
Update: replace usage of `WPTabBarController.sharedInstance()` in Sup…
hassaanelgarem Dec 27, 2022
e571333
Update: replace usages of some reader-related function
hassaanelgarem Dec 27, 2022
fb98daf
Update: remove unneeded optional casting
hassaanelgarem Dec 27, 2022
dc3bfca
Update: replace usages of `WPTabBarController.sharedInstance` related…
hassaanelgarem Dec 27, 2022
2a33e0b
Update: replace usages of `WPTabBarController.sharedInstance` as a VC
hassaanelgarem Dec 27, 2022
43862d6
Update: replace usages of `WPTabBarController.mySitesCoordinator`
hassaanelgarem Dec 27, 2022
fb65edc
Update: replace usages of `WPTabBarController.sharedInstance()` by ca…
hassaanelgarem Dec 27, 2022
9ea1a36
Update: move `currentOrLastBlog` to `RootViewPresenter`
hassaanelgarem Dec 27, 2022
57e4609
Refactor: add a new file for editor navigation extension
hassaanelgarem Dec 27, 2022
51a6982
Refactor: move showPostTab functions to `RootViewPresenter`
hassaanelgarem Dec 27, 2022
2ecdd7b
Refactor: move ShowTab functions to `RootViewPresenter`
hassaanelgarem Dec 27, 2022
ffcac18
Remove: Unneeded `WPTabBarController+ShowTab` file
hassaanelgarem Dec 27, 2022
f17c60f
Update: Replace usages of `WPTabBar.sharedInstance` in 3D touch handler
hassaanelgarem Dec 27, 2022
77fb5c6
Update: replace editor navigation usages of `WPTabBar.sharedInstance`
hassaanelgarem Dec 27, 2022
1119446
Update: replace usages of `tabBarController` with RootViewPresenter
hassaanelgarem Dec 27, 2022
fe3bd34
Refactor: move whats new logic to `RootViewControllerCoordinator`
hassaanelgarem Dec 27, 2022
2a9a886
Refactor: move blogging prompts logic to `RootViewControllerCoordinator`
hassaanelgarem Dec 27, 2022
67c8786
Update: remove usage of `WPTabBar.sharedInstance` in `BlogDetailsVC.m`
hassaanelgarem Dec 27, 2022
c450a6f
Update: Completely remove `WPTabBarController.sharedInstance()`
hassaanelgarem Dec 27, 2022
fde1ace
Update: Fix incorrect documentation
hassaanelgarem Dec 27, 2022
476a929
Merge branch 'task/19810-simplify-ui' into task/19812-handle-simplifi…
hassaanelgarem Dec 28, 2022
2b07177
Add: track incorrectly accessed jetpack functions
hassaanelgarem Dec 28, 2022
2f68760
Merge branch 'task/19810-simplify-ui' into task/19812-handle-simplifi…
hassaanelgarem Dec 28, 2022
d16a995
Refactor: rename `RootViewControllerCoordinator` to `RootViewCoordina…
hassaanelgarem Dec 28, 2022
d3f07f3
Add: release note
hassaanelgarem Dec 28, 2022
fb960a3
Update: make `RootViewPresenter.mySitesCoordinator` optional
hassaanelgarem Dec 29, 2022
f03e6c2
Update: Make `WPTabBarController.mySitesCoordinator` nullable
hassaanelgarem Dec 29, 2022
5a44295
Update: Add readerCoordinator to RootViewPresenter
hassaanelgarem Dec 29, 2022
9b95aa5
Update: Specify nullability identifiers for `WPTabBarController`
hassaanelgarem Dec 29, 2022
d897810
Update: Add `readerNavigationController` to RootViewPresenter
hassaanelgarem Dec 29, 2022
f3f2794
Update: Add `notificationsViewController` to RootViewPresenter
hassaanelgarem Dec 29, 2022
e619798
Update: Use `RootViewPresenter.readerTabVC` instead of accessing the …
hassaanelgarem Dec 29, 2022
c17f29e
Update: call `fallbackBehavior()` when accessing unsupported variables
hassaanelgarem Dec 29, 2022
9d7ec3c
Update: remove `shouldRemoveJetpackFeatures()` and depend on `jetpack…
hassaanelgarem Dec 29, 2022
3dcf3f7
Merge branch 'task/19810-simplify-ui' into task/19812-handle-simplifi…
hassaanelgarem Jan 1, 2023
aea0501
Fix: Replace deprecated `shouldRemoveJetpackFeatures` to fix build er…
hassaanelgarem Jan 1, 2023
1af613b
Update: make `mySitesCoordinator` non-optional
hassaanelgarem Jan 1, 2023
1775563
Merge branch 'trunk' into task/19812-handle-simplified-ui
hassaanelgarem Jan 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ extension MySitesCoordinator: RootViewPresenter {

func showMySitesTab() {
// Do nothing
// Landing here means we're trying to show the My Sites, but it's already showing.
}

// MARK: Notifications
Expand All @@ -111,9 +112,8 @@ extension MySitesCoordinator: RootViewPresenter {
// MARK: Helpers

/// Default implementation for functions that are not supported by the simplified UI.
private func fallbackBehavior() {
// TODO: Consider showing an overlay
// TODO: Print a log statement
// TODO: Consider tracking this
private func fallbackBehavior(callingFunction: String = #function) {
let properties = ["calling_function": callingFunction]
WPAnalytics.track(.jetpackFeatureIncorrectlyAccessed, properties: properties)
}
}
3 changes: 3 additions & 0 deletions WordPress/Classes/Utility/Analytics/WPAnalyticsEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ import Foundation
case jetpackBrandingMenuCardHidden
case jetpackBrandingMenuCardRemindLater
case jetpackBrandingMenuCardContextualMenuAccessed
case jetpackFeatureIncorrectlyAccessed

/// A String that represents the event
var value: String {
Expand Down Expand Up @@ -1141,6 +1142,8 @@ import Foundation
return "remove_feature_card_remind_later_tapped"
case .jetpackBrandingMenuCardContextualMenuAccessed:
return "remove_feature_card_menu_accessed"
case .jetpackFeatureIncorrectlyAccessed:
return "jetpack_feature_incorrectly_accessed"

} // END OF SWITCH
}
Expand Down