-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Jetpack Focus: Fix UI issues by removing the WPTabBarController dependency
#19817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
43f6e46
Update: replace Reader-related WPTabBarController.sharedInstance usages
hassaanelgarem 5866206
Refactor: MeNavigation as an extension on RootViewPresenter for reusa…
hassaanelgarem 0dfbf89
Fix: remove white spaces
hassaanelgarem 9a66698
Update: replace Search-related WPTabBarController.sharedInstance usages
hassaanelgarem ca886bb
Update: replace usages of `showNotificationsTab`
hassaanelgarem 493a27f
Update: replace usage of `showReaderTab(forPost:)`
hassaanelgarem 14fa3a5
Update: replace usages of `WPTabBarController.sharedInstance` in Me n…
hassaanelgarem 831de53
Update: replace usage of `showMedia(for:)`
hassaanelgarem 3e38635
Update: replace usage of `showPosts(for:)`
hassaanelgarem 1882ea1
Update: replace usages of `present()` and `dismiss()`
hassaanelgarem 8bab975
Update: replace usages of `WPTabBarController.sharedInstance()` in `P…
hassaanelgarem 8fbfd1b
Update: replace usages of `currentlySelectedScreen()`
hassaanelgarem cd976e8
Update: replace usages of `showBlogDetails()`
hassaanelgarem 19f48de
Update: replace usage of `WPTabBarController.sharedInstance()` in Sup…
hassaanelgarem e571333
Update: replace usages of some reader-related function
hassaanelgarem fb98daf
Update: remove unneeded optional casting
hassaanelgarem dc3bfca
Update: replace usages of `WPTabBarController.sharedInstance` related…
hassaanelgarem 2a33e0b
Update: replace usages of `WPTabBarController.sharedInstance` as a VC
hassaanelgarem 43862d6
Update: replace usages of `WPTabBarController.mySitesCoordinator`
hassaanelgarem fb65edc
Update: replace usages of `WPTabBarController.sharedInstance()` by ca…
hassaanelgarem 9ea1a36
Update: move `currentOrLastBlog` to `RootViewPresenter`
hassaanelgarem 57e4609
Refactor: add a new file for editor navigation extension
hassaanelgarem 51a6982
Refactor: move showPostTab functions to `RootViewPresenter`
hassaanelgarem 2ecdd7b
Refactor: move ShowTab functions to `RootViewPresenter`
hassaanelgarem ffcac18
Remove: Unneeded `WPTabBarController+ShowTab` file
hassaanelgarem f17c60f
Update: Replace usages of `WPTabBar.sharedInstance` in 3D touch handler
hassaanelgarem 77fb5c6
Update: replace editor navigation usages of `WPTabBar.sharedInstance`
hassaanelgarem 1119446
Update: replace usages of `tabBarController` with RootViewPresenter
hassaanelgarem fe3bd34
Refactor: move whats new logic to `RootViewControllerCoordinator`
hassaanelgarem 2a9a886
Refactor: move blogging prompts logic to `RootViewControllerCoordinator`
hassaanelgarem 67c8786
Update: remove usage of `WPTabBar.sharedInstance` in `BlogDetailsVC.m`
hassaanelgarem c450a6f
Update: Completely remove `WPTabBarController.sharedInstance()`
hassaanelgarem fde1ace
Update: Fix incorrect documentation
hassaanelgarem 476a929
Merge branch 'task/19810-simplify-ui' into task/19812-handle-simplifi…
hassaanelgarem 2b07177
Add: track incorrectly accessed jetpack functions
hassaanelgarem 2f68760
Merge branch 'task/19810-simplify-ui' into task/19812-handle-simplifi…
hassaanelgarem d16a995
Refactor: rename `RootViewControllerCoordinator` to `RootViewCoordina…
hassaanelgarem d3f07f3
Add: release note
hassaanelgarem fb960a3
Update: make `RootViewPresenter.mySitesCoordinator` optional
hassaanelgarem f03e6c2
Update: Make `WPTabBarController.mySitesCoordinator` nullable
hassaanelgarem 5a44295
Update: Add readerCoordinator to RootViewPresenter
hassaanelgarem 9b95aa5
Update: Specify nullability identifiers for `WPTabBarController`
hassaanelgarem d897810
Update: Add `readerNavigationController` to RootViewPresenter
hassaanelgarem f3f2794
Update: Add `notificationsViewController` to RootViewPresenter
hassaanelgarem e619798
Update: Use `RootViewPresenter.readerTabVC` instead of accessing the …
hassaanelgarem c17f29e
Update: call `fallbackBehavior()` when accessing unsupported variables
hassaanelgarem 9d7ec3c
Update: remove `shouldRemoveJetpackFeatures()` and depend on `jetpack…
hassaanelgarem 3dcf3f7
Merge branch 'task/19810-simplify-ui' into task/19812-handle-simplifi…
hassaanelgarem aea0501
Fix: Replace deprecated `shouldRemoveJetpackFeatures` to fix build er…
hassaanelgarem 1af613b
Update: make `mySitesCoordinator` non-optional
hassaanelgarem 1775563
Merge branch 'trunk' into task/19812-handle-simplified-ui
hassaanelgarem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.