Skip to content

Increase the migration welcome screen top inset in iOS 14 only #19822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022
+8 −2
Merged

Increase the migration welcome screen top inset in iOS 14 only #19822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...s/ViewRelated/WordPress-to-Jetpack Migration/Welcome/MigrationWelcomeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ final class MigrationWelcomeViewController: UIViewController {
])
}

/// Increases the tableView's bottom inset so it doesn't cover the bottom actions sheet.
/// Increases the tableView's bottom inset so it doesn't get covered by the bottom actions sheet.
private func updateTableViewContentInset() {
let bottomInset = -view.safeAreaInsets.bottom + bottomSheet.bounds.height
self.tableView.contentInset.bottom = bottomInset + Constants.tableViewBottomInsetMargin
Expand All @@ -116,7 +116,13 @@ final class MigrationWelcomeViewController: UIViewController {
static let tableViewLeadingMargin = CGFloat(30)

/// Used for the `tableHeaderView` layout guide margins.
static let tableHeaderViewMargins = NSDirectionalEdgeInsets(top: 0, leading: 30, bottom: 30, trailing: 30)
static let tableHeaderViewMargins: NSDirectionalEdgeInsets = {
var insets = NSDirectionalEdgeInsets(top: 20, leading: 30, bottom: 30, trailing: 30)
if #available(iOS 15, *) {
insets.top = 0
}
return insets
}()
}
}

Expand Down