-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Jetpack Focus: Add switch card to the menu in phase 4 #19833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
task/19811-remove-features-post-launch
to
trunk
January 4, 2023 16:22
momo-ozawa
approved these changes
Jan 6, 2023
Contributor
momo-ozawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
@momo-ozawa Nice catch! I've created #19873 to track this and added it to the project board as a low priority issue 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Closes #19813
Design ref: qk5s4q4mZsXknwhMWo2vIY-fi-439%3A5242
Description
This PR adds a "Switch to Jetpack" button to the bottom of the menu in phase 4. The card from phase 3 is reused here with a few modifications to match the design of the phase 4 card.
Screenshots
Testing Instructions
JetpackBrandingMenuCardPresenter.swiftline 173secondsInDayto any small value, 10, for examplesecondsInDayto 10, then wait for 40 seconds)Regression Notes
Potential unintended areas of impact
Phase 3 card
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing and
JetpackBrandingMenuCardPresenterTestsWhat automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.