Skip to content

Conversation

@hassaanelgarem
Copy link
Contributor

Closes #19813
Design ref: qk5s4q4mZsXknwhMWo2vIY-fi-439%3A5242

Description

This PR adds a "Switch to Jetpack" button to the bottom of the menu in phase 4. The card from phase 3 is reused here with a few modifications to match the design of the phase 4 card.

Screenshots

Light Mode Dark Mode
light dark

Testing Instructions

  1. Go to JetpackBrandingMenuCardPresenter.swift line 173
  2. Change the value of secondsInDay to any small value, 10, for example
  3. Launch the app
  4. Open the debug menu and enable "Jetpack Features Removal Phase Three"
  5. Kill and relaunch the app
  6. Make sure the menu card is displayed as the first menu item
  7. Make sure the card matches the design
  8. Make sure tapping the card displays the overlay
  9. Tap the ellipsis and tap on "Hide this"
  10. The card should be removed
  11. Open the debug menu and enable "Jetpack Features Removal Phase Four"
  12. Kill and relaunch the app
  13. Make sure the menu card is displayed as the last menu item
  14. Make sure the card is compact and matches the design
  15. Make sure tapping the card displays the overlay
  16. Tap the ellipsis and tap on "Remind me later"
  17. The card should be removed
  18. Wait for the duration to pass (If you set secondsInDay to 10, then wait for 40 seconds)
  19. Pull to refresh the menu
  20. Make sure the menu card is displayed

Regression Notes

  1. Potential unintended areas of impact
    Phase 3 card

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing and JetpackBrandingMenuCardPresenterTests

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added this to the 21.5 milestone Jan 4, 2023
@hassaanelgarem hassaanelgarem self-assigned this Jan 4, 2023
Base automatically changed from task/19811-remove-features-post-launch to trunk January 4, 2023 16:22
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! Nicely done :)

Not a blocker, but the FAB obscures the ellipsis button when the device is in landscape mode.

Simulator Screen Shot - iPhone 14 Pro - 2023-01-06 at 13 13 36

@hassaanelgarem
Copy link
Contributor Author

Not a blocker, but the FAB obscures the ellipsis button when the device is in landscape mode.

@momo-ozawa Nice catch! I've created #19873 to track this and added it to the project board as a low priority issue 👍

@hassaanelgarem hassaanelgarem merged commit 582294b into trunk Jan 8, 2023
@hassaanelgarem hassaanelgarem deleted the task/19813-phase-4-button branch January 8, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jetpack Focus: Add switch button to the menu in phase 4

3 participants