Jetpack app: Update tint color in editor's navigation bar #19887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
tintColorused in the editor's navigation bar differs across the WordPress and Jetpack apps.In the WordPress app, the publish button changes from grey to blue, which gives a user a clear indication that the post is ready to be published. There is a less clear indication in the Jetpack app, as the publish button always remains a shade of grey:
The reason for the difference is that
appBarTintis set to.primary(blue) here for WordPress and.text(a shade of grey) for Jetpack here.This PR addresses that issue by explicitly updating the
tintColorof the cancel and publish buttons within the editor to.editorPrimary, which was introduced in #19113. The buttons will now be blue in both the WordPress and Jetpack apps.Testing
To test:
Regression Notes
This PR should only change the colour in the editor's navigation bar, no other colours. The colours should also be the same across both apps and in dark/light modes.
Manually tested both apps and different modes.
No automated tests added as this is a really small change that I didn't feel warranted tests.
PR submission checklist:
RELEASE-NOTES.txtif necessary.