Skip to content

Conversation

@SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jan 11, 2023

Description

The tintColor used in the editor's navigation bar differs across the WordPress and Jetpack apps.

In the WordPress app, the publish button changes from grey to blue, which gives a user a clear indication that the post is ready to be published. There is a less clear indication in the Jetpack app, as the publish button always remains a shade of grey:

WordPress Jetpack

The reason for the difference is that appBarTint is set to .primary (blue) here for WordPress and .text (a shade of grey) for Jetpack here.

This PR addresses that issue by explicitly updating the tintColor of the cancel and publish buttons within the editor to .editorPrimary, which was introduced in #19113. The buttons will now be blue in both the WordPress and Jetpack apps.

Testing

To test:

  • Locally check out these changes and run the Jetpack app.
  • Navigate to the post or page editor and type in some text, so that the post/page is publishable.
  • Verify that the publish button changes from grey to blue.

Regression Notes

  1. Potential unintended areas of impact

This PR should only change the colour in the editor's navigation bar, no other colours. The colours should also be the same across both apps and in dark/light modes.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manually tested both apps and different modes.

  1. What automated tests I added (or what prevented me from doing so)

No automated tests added as this is a really small change that I didn't feel warranted tests.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB self-assigned this Jan 11, 2023
@SiobhyB SiobhyB added this to the 21.6 milestone Jan 11, 2023
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19887-bd35f26 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19887-bd35f26 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@SiobhyB SiobhyB marked this pull request as ready for review January 11, 2023 12:13
@SiobhyB SiobhyB requested a review from twstokes January 11, 2023 12:13
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jan 11, 2023

@twstokes, 👋 , as you were involved in reviewing the previous colour changes, I wondered if you might be able to take a look at this? Let me know if you're not available and I can find someone else. :) Thanks!

@twstokes
Copy link
Contributor

@twstokes, 👋 , as you were involved in reviewing the previous colour changes, I wondered if you might be able to take a look at this? Let me know if you're not available and I can find someone else. :) Thanks!

Sure @SiobhyB! 👋 Will be happy to.

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @SiobhyB! 🚀 Great work.

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Jan 11, 2023

Thank you @twstokes!

@SiobhyB SiobhyB merged commit 23b3818 into trunk Jan 11, 2023
@SiobhyB SiobhyB deleted the update/editor-navigation-bar-tint branch January 11, 2023 14:57
@SiobhyB SiobhyB changed the title Update tint color in editor's navigation bar Jetpack app: Update tint color in editor's navigation bar Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants