-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Jetpack Focus: New users phase menu card and overlay display logic #19894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Focus: New users phase menu card and overlay display logic #19894
Conversation
|
@enejb is working on adding a test account with the new users flag enabled. It would be great to test this PR using that test account when created, to make sure the feature flags are refreshed correctly during login. |
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
momo-ozawa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we meant to be showing the "Learn more at jetpack.com" button in the overlay? I thought we were hiding this link for the new user overlay?
|
@momo-ozawa I'm not entirely sure. I started this slack thread (p1673545326946679-slack-C04564QS0V7) to gain some clarity on this. |
|
@momo-ozawa I've applied the outcome of the slack thread in #19907 because it touches both new users and self-hosted phases. |

Closes #19453
Description
This PR adds the menu card for new users. It also tweaks when the remote feature flags are updated. Instead of updating them after login is complete, we update it them during login, so they are always ready post-login.
Screenshots
Pre-testing Instructions
JetpackFullscreenOverlayGeneralViewModel.swiftline 183return nilFeatureFlag.swiftline 130return trueFeatureFlag.swiftline 150return "dummy_key"Testing Instructions
Regression Notes
Potential unintended areas of impact
Sign-in and sign-up flows
What I did to test those areas of impact (or what existing automated tests I relied on)
Tested manually.
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.