Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 12, 2023

I noticed this while reading the encrypted logs in one of the tickets I worked on during my yearly support rotation.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

I noticed this while reading the encrypted logs in one of the tickets I
worked on during my yearly support rotation.
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.
⚠️ PR is missing at least one label.

Generated by 🚫 dangerJS

@mokagio mokagio added this to the 21.6 milestone Jan 12, 2023
@mokagio mokagio enabled auto-merge January 12, 2023 03:03
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19897-0d41204 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19897-0d41204 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@derekblank derekblank self-requested a review January 12, 2023 04:09
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👀 🚀

@mokagio mokagio merged commit 641ac88 into trunk Jan 12, 2023
@mokagio mokagio deleted the mokagio/fix-support-rotation-typo branch January 12, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants