Skip to content

Conversation

@dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Jan 12, 2023

Fixes #19877
Refs p5T066-3ND-p2#comment-14170, p5T066-3ND-p2#comment-14172

Warning: This depends on wordpress-mobile/WordPress-iOS-Shared#331. Once that PR is merged, the pod version of WordPressShared should be updated before merging this PR.

This fixes the issue of the Noto font family not loading correctly due to incorrect access to the resource bundle from the WordPressShared library.

To test:

  • Run the app.
  • Open any comment threads.
  • 🔍 Verify that the comment bodies are displayed with the Noto font family.
  • Open the editor.
  • 🔍 Verify that the title and body are displayed with the Noto font family.

Regression Notes

  1. Potential unintended areas of impact
    Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested the changes.

  3. What automated tests I added (or what prevented me from doing so)
    N/A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @dvdchr 🚀!

I tested:

  • Comments from Notifications
  • Comments in Reader
  • The editor

In both WordPress and Jetpack and they look correct. Thanks!

@dvdchr dvdchr changed the base branch from trunk to release/21.5 January 13, 2023 06:34
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 13, 2023

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19898-c5a973f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 13, 2023

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19898-c5a973f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@dvdchr dvdchr marked this pull request as ready for review January 16, 2023 16:51
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dvdchr dvdchr merged commit 8f35570 into release/21.5 Jan 16, 2023
@dvdchr dvdchr deleted the fix/noto-font-not-loading branch January 16, 2023 19:36
@mokagio mokagio mentioned this pull request Jan 17, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fonts are unstyled for comments

4 participants