-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Stats: Make Views & Visitors, Total Likes, and Total Comments cards data consistent with the Web #19900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Make Views & Visitors, Total Likes, and Total Comments cards data consistent with the Web #19900
Conversation
…Insights excluding today
- For routing to work, we need to include `.insightsFollowersWordPress` in allInsights - For insight management to work, we need to remove `insightsFollowersWordPress` to avoid double `Followers` rows appearing. It happens because `insightsFollowersWordPress` and insightsFollowersEmail` share the same `InsightType` and are represented by a single card.
|
@ravishanker, @irfano. Tagging you for reference, since there's identical ongoing ticket on Android. |
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
…b-by-excluding-today-from-week-insights
guarani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested by comparing the Views & Visitors card to the web and the data matches now since we're showing the same period (last 7 days excluding today).
Since we're close to shipping, I also smoke tested all the cards and everything seems to match the web. Nice work!
Fixes #19882
Description
Calculate Views & Visitors, Total Likes, and Total Comments card data on Insights tab in a similar way as on the web, by excluding today. Also, remove ambiguity by renaming This week and Last week to Last 7-days and Previous 7-days which explains the numbers more accurately.
Followerscard would not open details. A regression from #19830. Explaining in the commit and comment.Testing instructions
Before all:
Enable "New Appearance for Stats" and "New Cards for Stats Insights" feature flag
Case 1:
Regression Notes
Other cards start being represented in the wrong way when we switch to yesterday's date
Code analysis.
lastRequestedDateis only used for passing it toperiodStorewhich is only used for those 3 cards.PR submission checklist:
RELEASE-NOTES.txtif necessary.Images & Videos