WPAuthenticator - Remove custom step value from GetStartedViewController
#19940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selanthiraiyan
changed the title
GetStartedViewController
1 task
wpmobilebot
reviewed
Jan 18, 2023
Podfile
Outdated
| # pod 'WordPressAuthenticator', '~> 5.0' | ||
| # pod 'WordPressAuthenticator', git: 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', branch: 'trunk' | ||
| # pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :commit => '' | ||
| pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :commit => 'bf6681f979ea3edbc07021130cfc0f4644138575' |
Contributor
There was a problem hiding this comment.
| 🚫 | Use the new Ruby 1.9 hash syntax. |
Contributor
You can test the changes in WordPress from this Pull Request by:
|
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
wargcm
approved these changes
Jan 18, 2023
Contributor
wargcm
left a comment
wargcm
left a comment
There was a problem hiding this comment.
✅ I'm seeing 🔵 Tracked: unified_login_step <flow: wordpress_com, source: default, step: start> being tracked.
LGTM 🚀
Contributor
Author
selanthiraiyan
deleted the
bugfix/wpauthenticator-723-revert-step-value
branch
Contributor
@selanthiraiyan , for some reason, you weren't in any of the teams that have merge rights on this repo. That has now been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPressAuthenticator-iOS#723
Related to: wordpress-mobile/WordPressAuthenticator-iOS#724
Description
A previous update made to WordPress Authenticator changed the
stepvalue of an analytics event fromGetStartedViewController. This started impacting the looker dashboard of WordPress Mobile.To fix it, we have created a configuration flag and moved the
stepvalue change behind it.More details here
This PR updates the WordPress Authenticator pod to the latest release to revert the
stepvalue change.Testing Instructions
GetStartedViewController(Ref screenshot below)startand notenter_email_addressanymoreRegression Notes
Potential unintended areas of impact
NA
What I did to test those areas of impact (or what existing automated tests I relied on)
NA
What automated tests I added (or what prevented me from doing so)
NA
PR submission checklist:
RELEASE-NOTES.txtif necessary.