Jetpack Content Migration: Refactor "Open WordPress" screen to appear only when the app launches

[salimbraksa]

Fixes #19950

Description

This PR fixes an issue where the Login Flow was restarting every time the app enters the foreground. The solution that resolves this issue is showing the "Load WordPress" screen only if the rootViewController is nil.

Before	After
Simulator.Screen.Recording.-.iPhone.14.-.2023-01-19.at.12.40.53.mp4	CleanShot.2023-01-20.at.13.19.40.mp4

Test Instructions

Case 1: WordPress app installed

1. Clean install WordPress and log in.
2. Clean install the Jetpack app and run it.
3. Expect the "Load WordPress" screen to appear.
4. Tap "No Thanks".
5. Tap "Continue with WordPress.com".
6. Move the Jetpack app to background and open it again.
7. Expect to see the same screen you saw before moving the app to background.

Case 2: WordPress app not installed

1. Delete the WordPress app.
2. Kill the Jetpack app and run it again.
3. Expect the Login Prologue screen to appear.
4. Tap "Continue with WordPress.com".
5. Move the Jetpack app to background and open it again.
6. Expect to see the same screen you saw before moving the app to background.

Bonus

Although this PR shouldn't impact the content migration logic, but it would be great to make sure the migration flow is still working as expected. 🙇

Regression Notes

1. Potential unintended areas of impact
   This PR only impacts when the "Load WordPress" is shown. Previously it was shown every time the app enters foreground, now it only appears at launch.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manual testing.

3. What automated tests I added (or what prevented me from doing so)
   None.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19961-86a0ed4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19961-86a0ed4 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[twstokes]

This LGTM @salimbraksa! 🚀

I tested:

• The migration flow
• "No thanks" -> logging in
• "No thanks" -> restart -> migrating
• Clean install without WordPress installed
• On iPad

And didn't spot any issues. 👍

Currently the PR is targeted for trunk so we'll need to update that to the 21.5 release. Thanks!

[dvdchr]

I've also tested the steps, and it fixes the issue as described. 👍🏼

⚠️ However, it looks like there are some regressions in the flow. Tapping the "Open WordPress" button when the WordPress app is logged out leads to the "Load WordPress" screen again. Here's a recording:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-01-20.at.22.25.07.mp4

I suspect this is because after returning to WordPress and getting a migration error, the sign-in UI is not shown because the Load WordPress UI is currently being shown.

Additionally, when testing the local draft scenario (refer to no. 7 from the table below), it unexpectedly showed me the 🔁 Open WordPress flow when it should've been the 🔐 Sign-in flow. I'm suspecting the root cause is the same as the above 🤔

Here's a table:

No.	WordPress app	Account state	Scenario	Expected flow	Result
1	Not installed	n/a	n/a	🔐 Sign-in flow	unchanged
2	Incompatible	Any	Any	🔐 Sign-in flow	unchanged
3	Compatible	Logged out	Never opened	🔁 Open WordPress	unchanged
4	Compatible	Logged out	Log in > then tap the Jetpack banner	🟢 Normal migration	unchanged
5	Compatible	Logged in	Never opened	🔁 Open WordPress	unchanged
6	Compatible	Logged in	Tap the Jetpack banner	🟢 Normal migration	unchanged
7	Compatible	Logged in	Airplane mode > create local draft > tap the Jetpack banner	🔐 Sign-in flow	🔁 Open WordPress
8	Compatible	Logged in	Log out	🔐 Sign-in flow	unchanged

[dvdchr]

👋🏼 @salimbraksa, @twstokes. I've pushed f73e480 which should address all the issues I've raised in my previous comment.

Before	After
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-01-20.at.22.25.07.mp4	Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-01-20.at.23.17.00.mp4.mp4

Here are three test scenarios to verify:

1️⃣ Verifying that the Open WordPress loop is fixed:

• Clean install WordPress. Don't log in.
• Clean install Jetpack, and open it.
• 🔍 Verify that the Load WordPress flow is shown.
• Tap on the Open WordPress button.
• 🔍 After returning from the WordPress app, verify that the 🔐 Sign-in flow is shown.

2️⃣ Verifying the local draft scenario shows the 🔐 Sign-in flow:

• Clean install WordPress and log in to your WordPress.com account.
• Turn on airplane mode / disable wi-fi and publish a local post.
• Clean install Jetpack, and open it.
• 🔍 Verify that the Load WordPress flow is shown.
• Tap on the Open WordPress button.
• 🔍 After returning from the WordPress app, verify that the 🔐 Sign-in flow is shown.

3️⃣ Verifying that the original issue remains fixed:

• Clean install WordPress. Don't log in.
• Clean install Jetpack, and open it.
• 🔍 Verify that the Load WordPress flow is shown.
• Tap on the No thanks button.
• Tap Continue with WordPress.com.
• Minimize the Jetpack app, and then open it again.
• 🔍 Verify that the app is still showing the unified login flow.

---

Lastly, here's the updated table for the overall migration pathways:

No.	WordPress app	Account state	Scenario in WP	Flow after f73e480
1	Not installed	n/a	n/a	🔐 Sign-in flow
2	Incompatible	Any	Any	🔐 Sign-in flow
3	Compatible	Logged out	Never opened	🔁 Open WordPress
4	Compatible	Logged out	Log in > then tap the Jetpack banner	🟢 Normal migration
5	Compatible	Logged in	Never opened	🔁 Open WordPress
6	Compatible	Logged in	Tap the Jetpack banner	🟢 Normal migration
7	Compatible	Logged in	Airplane mode > create local draft > tap the Jetpack banner	🔐 Sign-in flow
8	Compatible	Logged in	From scenario no. 5: Switch to WP > Log out > Switch to JP > Tap Open WordPress	🔐 Sign-in flow
9	Compatible	Logged in	From scenario no. 5: Tap 'No thanks' > Tap 'Log in with WordPress.com' > Background the app > Foreground the app again	Stay in Unified Login flow

[twstokes]

Thank you @dvdchr for the catch and fix!

It appears what's left is to target this for the release/21.5 branch which will require a rebase. I'll be happy to help test all these scenarios again once that's done. 🙇

I'll also be happy to wrangle this and force-push it - so just let me know. 👍

Update: This is done and I'm going to re-test now.

[salimbraksa]

Thanks @twstokes for rebasing this PR. I was about to work on that. I'll help with testing as well.

[twstokes]

I tested:

• Tests 6-9
• PR test cases 1-2

And all succeeded. 🎉

[salimbraksa]

I tested the following:

• The 1️⃣ 2️⃣ and 3️⃣ scenarios from this comment
• Tests 1-5

All good 🚀