Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 23, 2023

This should avoid noisy lint errors such as this
#19807 (comment)

image

The method I used to make these changes was to uncomment all the suggestions, run RuboCop with -A, and recomment.

Testing

This PR only touches comments. So there's nothing to test.

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

This should avoid noisy lint errors such as this
#19807 (comment)
Podfile Outdated

pod 'WPMediaPicker', '~> 1.8.7'
# pod 'WPMediaPicker', :git => 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', :tag => '1.7.0'
# pod 'WPMediaPicker', git: 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', tag: '1.7.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we should delete this because it adds little to what we can already do with the standard syntax.

I suppose it might have been useful in the past, before we had our own specs source repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# pod 'WPMediaPicker', git: 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', tag: '1.7.0'

@mokagio mokagio force-pushed the mokagio/podfile-ruby-updates branch from 46745e7 to 880311f Compare January 23, 2023 04:03
@mokagio mokagio enabled auto-merge January 23, 2023 04:03
@mokagio mokagio requested a review from a team January 23, 2023 04:04
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Jan 23, 2023
@mokagio mokagio added this to the 21.6 ❄️ milestone Jan 23, 2023
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19963-880311f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19963-880311f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@mokagio mokagio merged commit b146b82 into trunk Jan 23, 2023
@mokagio mokagio deleted the mokagio/podfile-ruby-updates branch January 23, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants