Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Jan 23, 2023

  • Update internal Pods to stable version
  • New version header in RELEASE-NOTE.txt
  • Localizable.strings updated
  • release_notes.txt updated with notes from RELEASE-NOTE.txt for current version
  • Version update in .xcconfig

@mokagio mokagio requested a review from a team January 23, 2023 04:35
@mokagio mokagio self-assigned this Jan 23, 2023
@mokagio mokagio added this to the 21.6 ❄️ milestone Jan 23, 2023
@mokagio mokagio enabled auto-merge January 23, 2023 04:35
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19964-cea2210 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19964-cea2210 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@spencertransier spencertransier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved minus the merge conflict with Podfile.lock. I switched to that branch and ran bundle exec pod install, but it didn't update the checksum. What's the correct way to resolve that conflict?

@mokagio
Copy link
Contributor Author

mokagio commented Jan 24, 2023

What's the correct way to resolve that conflict?

To resolve the conflict, we need to attempt to merge the base branch into the PR branch. This operation will result in the conflict locally. We can then manually address it and commit the merge.

You already know this, but for reference: Since this is a release/* branch, we don't want to merge trunk into it, or all the other changes that landed on trunk since cutting release/21.6 will end up in the next beta. Instead, we create a new branch from release/21.6 and do the merge, resolution, and PR there. See #19973.

I switched to that branch and ran bundle exec pod install, but it didn't update the checksum.

There are instances in which CI raises inconsistency issues in the Podfile.lock. Running bundle exec pod install on the branch that raised the error usually results in the checksum updating, because the most usual cause of the issue in the first place is a change in Podfile that was not followed by running that command. However, notice that this kind of CI error is not a merge conflict.

@mokagio
Copy link
Contributor Author

mokagio commented Jan 24, 2023

Closing in favor of #19973.

@mokagio mokagio closed this Jan 24, 2023
auto-merge was automatically disabled January 24, 2023 01:48

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants