Skip to content

[Stats Revamp] Fix crash after backgrounding app from Stats screen #20008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2023
Merged

[Stats Revamp] Fix crash after backgrounding app from Stats screen #20008

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3967465
Avoid NSAttributedString crashing the app when it's being initialized…
staskus Jan 26, 2023
609edd9
Don't rebuild guide view when the app is in the background
staskus Jan 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions WordPress/Classes/ViewRelated/Stats/Insights/StatsTotalInsightsCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,12 @@ class StatsTotalInsightsCell: StatsBaseCell {

// Rebuilds guide view for accessibility only if guide view already exists
private func rebuildGuideViewIfNeeded() {
/// NSAttributedString initialized with HTML on the background crashes the app
/// This method can be called when traitCollectionDidChange which can be triggered when app goes to background
guard UIApplication.shared.applicationState != .background else {
return
}

if guideText != nil,
let statsSummaryType = statsSummaryType,
let guideText = StatsTotalInsightsData.makeTotalInsightsGuideText(lastPostInsight: lastPostInsight, statsSummaryType: statsSummaryType) {
Expand Down