Fix deadlock that can occur when initializing RootViewCoordinator

[hassaanelgarem]

Fixes #20297

Description

I was unable to reproduce the crash, but from the stack trace, it's obvious that it's a deadlock. The deadlock is triggered by initializing the shared instance of RootViewCoordinator. Apparently, in some cases, the code path of initializing RootViewCoordinator ends up in NotificationsViewController.configureJetpackBanner, which calls RootViewCoordinator.shared to decide if JP features are enabled or not. To fix this deadlock, I've removed the dependency of JetpackFeaturesRemovalCoordinator.jetpackFeaturesEnabled on RootViewCoordinator.

Testing Instructions

I wasn't able to reproduce the crash, so there are no specific testing instructions. Please review the code carefully. And retest #20275's testing instructions because the fix in this PR overrides the changes made in #20275.

Regression Notes

1. Potential unintended areas of impact
   Jetpack features removal

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Manually tested going back and forth from the normal phase, phase 4, and new users phase.
   I also retested Jetpack Focus: Avoid premature removal of features #19954's testing instructions.

3. What automated tests I added (or what prevented me from doing so)
   N/A

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr20300-177cbde on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[momo-ozawa]

Apparently, in some cases, the code path of initializing RootViewCoordinator ends up in NotificationsViewController.configureJetpackBanner, which calls RootViewCoordinator.shared to decide if JP features are enabled or not.

Nice work investigating! I looked at the code and everything checks out. I also tested manually according to instructions on #20275 - works as described.

[momo-ozawa]

FYI @mokagio 🙇‍♀️

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr20300-177cbde on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[peril-wordpress-mobile]

	Warnings
⚠️	This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS