-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Merge 22.5 code freeze #20750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 22.5 code freeze #20750
Conversation
This version enables auto-retry for GlotPress downloads that fail with HTTP 429 by default. Awesome!
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20750-d503b20 | |
| Version | 22.5 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | d503b20 | |
| App Center Build | WPiOS - One-Offs #5796 |
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20750-d503b20 | |
| Version | 22.5 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | d503b20 | |
| App Center Build | jetpack-installable-builds #4826 |
Generated by 🚫 dangerJS |
oguzkocer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mokagio WordPressKit & WPMediaPicker seems to still be on a beta version. I might have missed a communication about this and it might be correct, but I wanted to bring your attention to it just in case.
I am approving the PR so that we have the strings in trunk ready for translation as soon as possible.
|
|
||
| def wordpress_kit | ||
| pod 'WordPressKit', '~> 8.2.0-beta.1' | ||
| pod 'WordPressKit', '~> 8.2-beta' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a stable version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @oguzkocer, thank you for raising this. This is the version specifier in the Podfile and it says "get everything compatible with 8.2, including betas. This way, we can run bundle exec pod update and get the latest compatible version without having to change the rule.
At least, in theory. You comment made me realize that I run install instead of update, resulting in WordPressKit staying at 8.2.0-beta.1. d503b20 rectifies this. Thanks!
I've been using this style for a while, but it's either not self explanatory enough or just not a good fit for our current workflow, as folks keep changing the value in the Podfile to get what they need, as opposed to run update. There's also the chance that a beta version will make it into a release, although I think we have enough review in place to catch that 🤔
Keen to hear what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it says "get everything compatible with 8.2, including betas
I might be wrong, but I don't think this is what we want. We want to only use stable versions - at least according to the release scenario.
My preference would be to be explicit with our intentions in Podfile. However, I don't think it's a big deal either way as long as we are using the correct version.
| pod 'NSURL+IDN', '~> 0.4' | ||
|
|
||
| pod 'WPMediaPicker', '~> 1.8.8-beta.1' | ||
| pod 'WPMediaPicker', '~> 1.8-beta' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a stable version?
|
I'm going to merge this to get on with the code freeze process and send the strings up for translation. |


RELEASE-NOTE.txtLocalizable.stringsupdatedrelease_notes.txtupdated with notes fromRELEASE-NOTE.txtfor current version.xcconfigNote that UI tests are currently failing. We are working on a fix, see #20728 (comment)