Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented May 29, 2023

  • Update internal Pods to stable version
  • New version header in RELEASE-NOTE.txt
  • Localizable.strings updated
  • release_notes.txt updated with notes from RELEASE-NOTE.txt for current version
  • Version update in .xcconfig

Note that UI tests are currently failing. We are working on a fix, see #20728 (comment)

@mokagio mokagio self-assigned this May 29, 2023
@mokagio mokagio requested a review from a team May 29, 2023 02:29
@mokagio mokagio marked this pull request as ready for review May 29, 2023 02:29
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 29, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20750-d503b20
Version22.5
Bundle IDorg.wordpress.alpha
Commitd503b20
App Center BuildWPiOS - One-Offs #5796
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 29, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20750-d503b20
Version22.5
Bundle IDcom.jetpack.alpha
Commitd503b20
App Center Buildjetpack-installable-builds #4826
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ The AppStoreStrings.po file must be updated any time changes are made to release notes
Messages
📖 This PR has the 'Releases' label: some checks will be skipped.

Generated by 🚫 dangerJS

Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mokagio WordPressKit & WPMediaPicker seems to still be on a beta version. I might have missed a communication about this and it might be correct, but I wanted to bring your attention to it just in case.

I am approving the PR so that we have the strings in trunk ready for translation as soon as possible.


def wordpress_kit
pod 'WordPressKit', '~> 8.2.0-beta.1'
pod 'WordPressKit', '~> 8.2-beta'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a stable version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @oguzkocer, thank you for raising this. This is the version specifier in the Podfile and it says "get everything compatible with 8.2, including betas. This way, we can run bundle exec pod update and get the latest compatible version without having to change the rule.

At least, in theory. You comment made me realize that I run install instead of update, resulting in WordPressKit staying at 8.2.0-beta.1. d503b20 rectifies this. Thanks!

I've been using this style for a while, but it's either not self explanatory enough or just not a good fit for our current workflow, as folks keep changing the value in the Podfile to get what they need, as opposed to run update. There's also the chance that a beta version will make it into a release, although I think we have enough review in place to catch that 🤔

Keen to hear what you think.

Copy link
Contributor

@oguzkocer oguzkocer May 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it says "get everything compatible with 8.2, including betas

I might be wrong, but I don't think this is what we want. We want to only use stable versions - at least according to the release scenario.


My preference would be to be explicit with our intentions in Podfile. However, I don't think it's a big deal either way as long as we are using the correct version.

pod 'NSURL+IDN', '~> 0.4'

pod 'WPMediaPicker', '~> 1.8.8-beta.1'
pod 'WPMediaPicker', '~> 1.8-beta'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a stable version?

@mokagio
Copy link
Contributor Author

mokagio commented May 30, 2023

trunk now contains a fix for the UI tests failure, see #20752.

I'm going to merge this to get on with the code freeze process and send the strings up for translation.

@mokagio mokagio merged commit 17ad862 into trunk May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants