Skip to content

TESTING ONLY: Ensure dictating text doesn't cause cursor to be offset on iOS #20881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

TESTING ONLY: Ensure dictating text doesn't cause cursor to be offset on iOS #20881

wants to merge 2 commits into from

Conversation

@SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Jun 15, 2023 •
edited
Loading

This PR has been created purely for the purpose of testing WordPress/gutenberg#51528.

@SiobhyB SiobhyB self-assigned this Jun 15, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 15, 2023 •
edited
Loading

Fails
🚫 Podfile: reference to a commit hash for Gutenberg,RNTAztecView

Generated by 🚫 dangerJS

@SiobhyB SiobhyB added this to the Someday milestone Jun 15, 2023
wpmobilebot
wpmobilebot reviewed Jun 15, 2023
View reviewed changes
Gutenberg/version.rb Outdated
GUTENBERG_CONFIG = {
# commit: '',
tag: 'v1.97.0'
commit: '13d2725cab18d9f9ea318c19b42e588a5acf3c98',
Copy link
Contributor

@wpmobilebot wpmobilebot Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Avoid comma after the last item of a hash.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 15, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20881-7bfc31f
Version22.6
Bundle IDorg.wordpress.alpha
Commit7bfc31f
App Center BuildWPiOS - One-Offs #6000
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 15, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20881-7bfc31f
Version22.6
Bundle IDcom.jetpack.alpha
Commit7bfc31f
App Center Buildjetpack-installable-builds #5029
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@SiobhyB SiobhyB mentioned this pull request Jun 15, 2023
Merged
@SiobhyB SiobhyB closed this Jun 19, 2023
@SiobhyB SiobhyB deleted the gutenberg/fix-dictation-cursor-position branch June 19, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpmobilebot wpmobilebot wpmobilebot left review comments

Assignees

@SiobhyB SiobhyB

Labels

Accessibility [Status] DO NOT MERGE

Projects

None yet

Milestone

Someday

Development

Successfully merging this pull request may close these issues.

3 participants

@SiobhyB @wpmobilebot