Skip to content

Conversation

@tiagomar
Copy link
Contributor

Description

This PR disables testPagesCardHeaderNavigation() to reduce the noise while working on a proper fix.

Testing

CI must be 🟢.

@tiagomar tiagomar added the Testing Unit and UI Tests and Tooling label Aug 21, 2023
@tiagomar tiagomar added this to the Someday milestone Aug 21, 2023
@tiagomar tiagomar requested a review from a team August 21, 2023 16:39
@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21379-ad9ab94
Version23.0
Bundle IDcom.jetpack.alpha
Commitad9ab94
App Center Buildjetpack-installable-builds #5819
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@pachlava pachlava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this kind of change, no deep review is needed. The fact of not seeing testPagesCardHeaderNavigation executed on CI (which is the case) is enough for 🚢. Thanks, @tiagomar!

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21379-ad9ab94
Version23.0
Bundle IDorg.wordpress.alpha
Commitad9ab94
App Center BuildWPiOS - One-Offs #6779
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@tiagomar tiagomar merged commit 6582af6 into trunk Aug 21, 2023
@tiagomar tiagomar deleted the ui-tests-disable-test-for-fixing branch August 21, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants