Skip to content

Reader: Recalculate cell height when Discover tab is reloaded #21888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Reader: Recalculate cell height when Discover tab is reloaded #21888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35e0101
Add a workaround to reload cell height of recommended tags
dvdchr Oct 25, 2023
2255b4e
Merge remote trunk into fix/21867-recommended-tags-layout-issue
mokagio Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions WordPress/Classes/ViewRelated/Reader/ReaderStreamViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,20 @@ import Combine
content.refresh()
refreshTableViewHeaderLayout()

// TODO: Find a better fix.
// This is a workaround to get the recommended tags card to properly resize after reloading content on tab change.
// Even though the collection view layout returned the correct height, the cell somehow kept its original bounds.
//
// This workaround is limited only to the Discover feed, to prevent unwanted side effects on other tabs.
// Also because the recommended tags card is only shown in Discover.
if let topic = readerTopic,
RemoteFeatureFlag.readerImprovements.enabled(),
ReaderHelpers.topicIsDiscover(topic) {
DispatchQueue.main.async {
self.heightDidChange()
}
}

if synchronize {
syncIfAppropriate()
}
Expand Down