Assert tests with localized values

[dvdchr]

Hi @momo-ozawa and @hassaanelgarem 👋🏼 , I'm assigning y'all as reviewers based on GitHub recommendations.

Some of the unit test cases failed locally because the assertions expected the code to use , as the thousands separator and . as the decimal separator. However, in my locale en_ID, it is the other way around (e.g. 10.000, 1,25M).

This PR addresses the issue by using the abbreviatedString(forHeroNumber:) for the expected value so it adjusts properly in different locales.

Alternatively, we can also force all local test runs to run in the UTC timezone and use en_US locale, but I'm not sure if this is the best way. 🤔 cc-ing @mokagio in case you have thoughts on this.

To test

• Go to WordPressUnitTests.xctestplan > Configuration.
• In the Localization > Application Region field, select Indonesia.
• 🔎 Run DashboardStatsViewModelTests.testReturnedDataIsFormattedCorrectly() and BlazeCampaignViewModelTests.testViewModel() and verify that they are passing.
• 🔎 Re-run the tests in your local region, and ensure that they are also passing.

Regression Notes

1. Potential unintended areas of impact
   Should be none.

2. What I did to test those areas of impact (or what existing automated tests I relied on)
   Ran the tests in both local and US locale.

3. What automated tests I added (or what prevented me from doing so)
   N/A.

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

Not applicable.

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr21982-e0240de
	Version	23.6
	Bundle ID	org.wordpress.alpha
	Commit	e0240de
	App Center Build	WPiOS - One-Offs #7720

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr21982-e0240de
	Version	23.6
	Bundle ID	com.jetpack.alpha
	Commit	e0240de
	App Center Build	jetpack-installable-builds #6736

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[momo-ozawa]

Thanks for addressing this!

[mokagio]

Thanks for looking into this @dvdchr.

By calling abbreviatedString() here, it seems like we are testing more at the implementation level than the behavior level. That is, reading the test one doesn't learn what the expected impressions value, only that it should be whatever abbreviatedString() returns.

For reference, here's the production code, which, unsurprisingly, calls abbreviatedString():

WordPress-iOS/WordPress/Classes/ViewRelated/Blog/Blog Dashboard/Cards/Blaze/DashboardBlazeCampaignView.swift

Line 144 in 697186e

self.impressions = campaign.stats?.impressionsTotal?.abbreviatedString() ?? "0"

This is probably okay practically, because we are not likely are we to change this formatting...

Still, I think we would be better served by making the application language and region deterministic, as you suggested in the PR description.

[hassaanelgarem]

Still, I think we would be better served by making the application language and region deterministic, as you suggested in the PR description.

Plus 1 on this. While this fixes tests for Indonesian, I tried running DashboardStatsViewModelTests with Arabic as the locale, and it still failed.

[dvdchr]

Hey, a quick update. As per @mokagio and @hassaanelgarem 's inputs, I tried updating the WordPressUnitTests.xctestplan configuration to use the English language and United States as the location but found additional new tests failing under this setting.

Unfortunately, I'll need to put this on hold this week as I need to wrap up my project work. I'll take another look at my downtime during the meetup. In the meantime, I'll clear the milestone target and set this to Draft for now.

[mokagio]

Thank you for the update @dvdchr