Remove WPMediaPicker dependency

[kean]

Removes WPMediaPicker dependency

To test:

• Smoke test Gutenberg: verify you can add images from Photos and Site Media
• Smoke test Site Media: verify that you can open video previews
• Smoke test Site Icon Picker: verify that picking from Site Media works

Regression Notes

1. Potential unintended areas of impact: Media
2. What I did to test those areas of impact (or what existing automated tests I relied on): manual
3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes testing checklist:

• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[peril-wordpress-mobile]

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr22103-f51be52
	Version	23.7
	Bundle ID	org.wordpress.alpha
	Commit	f51be52
	App Center Build	WPiOS - One-Offs #7982

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr22103-f51be52
	Version	23.7
	Bundle ID	com.jetpack.alpha
	Commit	f51be52
	App Center Build	jetpack-installable-builds #7006

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[momo-ozawa]

Works as described w a few comments

[momo-ozawa]

Suggested change

	mediaPickerHelper.presentSiteMediaPickere(filter: filter, allowMultipleSelection: allowMultipleSelection) { [weak self] assets in
	mediaPickerHelper.presentSiteMediaPicker(filter: filter, allowMultipleSelection: allowMultipleSelection) { [weak self] assets in

[kean]

Fixed 😓

[momo-ozawa]

wdyt of combining this with the item below this one?

[kean]

I changed the entry:

* [*] [internal] Rework Tenor (Free GIF) and Stock Photos (Free Photos) pickers [#22066, #22074]

The goal was to highlight the fact that Tenor and Stock photos changed. So it's more than just about removing WPMediaPicker, and it needs some testing.

[wpmobilebot]

	1 Warning
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger