Skip to content

Conversation

@jostnes
Copy link
Contributor

@jostnes jostnes commented Dec 1, 2023

Description

This fixes the failing testCreateScheduledPost() in PostTests in iPhone (the issue was also reproducible locally) that happened because the first day in the next month's calendar can't be selected. The fix is adding a condition to ensure that the month has changed before the tap.

Testing

CI should be 🟢 and testCreateScheduledPost() should pass on iPhone

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 1, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22135-077d381
Version23.8
Bundle IDcom.jetpack.alpha
Commit077d381
App Center Buildjetpack-installable-builds #7040
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 1, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22135-077d381
Version23.8
Bundle IDorg.wordpress.alpha
Commit077d381
App Center BuildWPiOS - One-Offs #8017
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@jostnes jostnes added the Testing Unit and UI Tests and Tooling label Dec 1, 2023
@jostnes jostnes added this to the 23.9 milestone Dec 1, 2023
@jostnes jostnes marked this pull request as ready for review December 1, 2023 08:16
@jostnes jostnes requested a review from a team as a code owner December 1, 2023 08:16
@jostnes jostnes changed the title add condition before calendar element tap [UI Tests] - Fix failing testCreateScheduledPost test Dec 1, 2023
Copy link
Contributor

@tiagomar tiagomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @jostnes ! 🙇‍♂️

I tested the changes locally and could reproduce the issue after reverting this PRs changes. The only thing I would add is that the issue also impacted iPad. :shipit:

@tiagomar tiagomar merged commit 3f6941f into trunk Dec 4, 2023
@tiagomar tiagomar deleted the fix-failing-create-scheduled-post-test branch December 4, 2023 20:55
fluiddot pushed a commit that referenced this pull request Dec 5, 2023
* add condition before calendar element tap

* fix Trailing Whitespace Violation
@mokagio mokagio mentioned this pull request Dec 6, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants