Skip to content

Conversation

@momo-ozawa
Copy link
Contributor

Description

Fixes an issue where the everyone icon was the wrong color in dark mode

Before After (dark mode) After (light mode)

How to test

  • Turn on dark mode
  • Switch to a site that has multiple authors
  • Go to posts and pages
  • Verify the everyone icon is white

Regression Notes

  1. Potential unintended areas of impact
    Posts & Pages light mode

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested manually

  3. What automated tests I added (or what prevented me from doing so)
    See screenshot above

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

fixes an issue where the everyone icon was the wrong color in dark mode
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 7, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22172-281628f
Version23.8
Bundle IDorg.wordpress.alpha
Commit281628f
App Center BuildWPiOS - One-Offs #8072
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised! LGTM :shipit:

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 7, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22172-281628f
Version23.8
Bundle IDcom.jetpack.alpha
Commit281628f
App Center Buildjetpack-installable-builds #7092
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Co-authored-by: David Christiandy <[email protected]>
@momo-ozawa momo-ozawa enabled auto-merge December 7, 2023 14:02
@wpmobilebot
Copy link
Contributor

1 Warning
⚠️ This PR is assigned to the milestone 23.9. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@momo-ozawa momo-ozawa merged commit 9ddcbe5 into trunk Dec 7, 2023
@momo-ozawa momo-ozawa deleted the fix/everyone-icon-tint branch December 7, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants