[UI Test] Dismiss image optimization popup #22237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagomar
commented
Dec 15, 2023
| } | ||
|
|
||
| private let turnOnImageOptimizationButtonGetter: (XCUIApplication) -> XCUIElement = { | ||
| private let leaveOnImageOptimizationButtonGetter: (XCUIApplication) -> XCUIElement = { |
Contributor
Author
There was a problem hiding this comment.
Renaming so it matches the button text.
alpavanoglu
approved these changes
Dec 15, 2023
Contributor
alpavanoglu
left a comment
alpavanoglu
left a comment
There was a problem hiding this comment.
LGTM
If CI passes we should be good to go. I think we can enable auto-merge.
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22237-63152cb | |
| Version | 23.9 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 63152cb | |
| App Center Build | WPiOS - One-Offs #8153 |
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22237-63152cb | |
| Version | 23.9 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 63152cb | |
| App Center Build | jetpack-installable-builds #7173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After introducing the Image Optimization popup #21981,
testAddGalleryBlock()started failing in CI. Actually, only its first run would fail as the popup wouldn't show up in the retry run.This PR adds the ability to dismiss this popup after adding images to the editor.
To test
testAddGalleryBlock()should pass in the first try on CI. - Popup is displayed.testAddMediaBlocks()should pass in the first try on CI. - Popup is NOT displayed.