Skip to content

Conversation

@tiagomar
Copy link
Contributor

This is a follow up PR to #22822.

While a typical test execution time in local stays under 0.2 seconds (0.148s for the first run, averaging 0.002 in subsequent runs), on CI the numbers are a bit worse.

image

In the last 28 days, the failed runs were generaly over 1s, 95% under 2.63s, but we still got a singe 3.75s run.

This PR sets the timeout to 5s for this test, which is not too high to compromise the Unit Tests performance.

@tiagomar tiagomar requested review from a team and twstokes March 13, 2024 17:46
@tiagomar tiagomar added the Testing Unit and UI Tests and Tooling label Mar 13, 2024
@tiagomar tiagomar added this to the Someday milestone Mar 13, 2024
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tiagomar! Fingers crossed 🤞 that it just needs more time to spin up IO sometimes.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22827-22f3901
Version24.4
Bundle IDcom.jetpack.alpha
Commit22f3901
App Center Buildjetpack-installable-builds #8190
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22827-22f3901
Version24.4
Bundle IDorg.wordpress.alpha
Commit22f3901
App Center BuildWPiOS - One-Offs #9146
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@tiagomar tiagomar merged commit d5bb7dc into trunk Mar 13, 2024
@tiagomar tiagomar deleted the unit-tests-improvements-take-2 branch March 13, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants