[Tooling] finalize_release lane: Add back hotfix validation and remove unused lane parameter
#23674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23674-38ac3e5 | |
| Version | 25.4 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 38ac3e5 | |
| App Center Build | jetpack-installable-builds #9868 |
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23674-38ac3e5 | |
| Version | 25.4 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 38ac3e5 | |
| App Center Build | WPiOS - One-Offs #10826 |
mokagio
reviewed
Oct 17, 2024
fastlane/lanes/release.rb
Outdated
| desc 'Trigger the final release build on CI' | ||
| lane :finalize_release do |options, skip_confirm: false| | ||
| lane :finalize_release do |skip_confirm: false| | ||
| UI.user_error!('To finalize a hotfix, please use the `finalize_hotfix_release` lane instead') if release_is_hotfix? |
Contributor
There was a problem hiding this comment.
There's something about "release_is_hotfix?" that sounds odd.
I was going to suggest adding branch in the name, but that would be incorrect because the check is on the version file not the branch name.
Maybe current_version_is_hotfix? or is_hotfix?.
Not sure...
Contributor
Author
There was a problem hiding this comment.
I got this method from Woo, which seems to have its name based on a release-toolkit method, but I agree -- renamed to current_version_hotfix? on 38ac3e5.
mokagio
approved these changes
Oct 17, 2024
iangmaia
force-pushed
the
iangmaia/fastlane-remove-unnecessary-params
branch
from
5153131 to
0245a0c
Compare
iangmaia
force-pushed
the
iangmaia/fastlane-remove-unnecessary-params
branch
from
0245a0c to
38ac3e5
Compare
oguzkocer
reviewed
Dec 13, 2024
|
|
||
| def current_version_hotfix? | ||
| # Read the current release version from the .xcconfig file and parse it into an AppVersion object | ||
| current_version = VERSION_FORMATTER.parse(VERSION_FILE.read_release_version) |
Contributor
Contributor
Author
There was a problem hiding this comment.
it was supposed to be
PUBLIC_VERSION_FILE
Indeed, that is the case. Thanks for changing it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the release backmerge #23673, where a couple of errors had to be fixed after running
finalize_release: the laneios_current_branch_is_hotfixwas removed fromrelease-toolkitbut was still being used, and theoptionsparameter was removed while still being passed todownload_localized_strings_and_metadata(though not used).This PR adds back the hotfix validation and properly removes the
optionsparameter.