Skip to content

Conversation

@crazytonyli
Copy link
Contributor

This is the alternative solution to #23654.

Eventually, we'd want to add multi-account support, we'll disable signing in with another WP.com account for now.

However, it's also important that we don't make the assumption that there is only one WPAccount. Always looking up accounts based on context (username, email, account associated with a given site, etc) will make our life easier when adding multi-account support to the app.

Before After
pr-before pr-after

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.5 milestone Oct 22, 2024
@crazytonyli crazytonyli requested review from jkmassel and kean October 22, 2024 01:13
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 22, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 22, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23682-8ceb405
Version25.4.1
Bundle IDorg.wordpress.alpha
Commit8ceb405
App Center BuildWPiOS - One-Offs #10887
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 22, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23682-8ceb405
Version25.4.1
Bundle IDcom.jetpack.alpha
Commit8ceb405
App Center Buildjetpack-installable-builds #9928
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean
Copy link
Contributor

kean commented Oct 24, 2024

It works as described.

Screenshot 2024-10-24 at 12 50 57 PM

It's not great, but at least it's now (more) clear what's going on.

@crazytonyli crazytonyli enabled auto-merge October 29, 2024 00:03
@crazytonyli crazytonyli added this pull request to the merge queue Oct 29, 2024
Merged via the queue into trunk with commit 0416ee8 Oct 29, 2024
24 checks passed
@crazytonyli crazytonyli deleted the bugfix/sign-in-jetpack-connected-sites branch October 29, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants