-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Prevent signing in with another WP.com account #23682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23682-8ceb405 | |
| Version | 25.4.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 8ceb405 | |
| App Center Build | WPiOS - One-Offs #10887 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23682-8ceb405 | |
| Version | 25.4.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 8ceb405 | |
| App Center Build | jetpack-installable-builds #9928 |
Contributor
kean
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



This is the alternative solution to #23654.
Eventually, we'd want to add multi-account support, we'll disable signing in with another WP.com account for now.
However, it's also important that we don't make the assumption that there is only one
WPAccount. Always looking up accounts based on context (username, email, account associated with a given site, etc) will make our life easier when adding multi-account support to the app.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: