Skip to content

Conversation

@pinarol
Copy link
Contributor

@pinarol pinarol commented Oct 25, 2024

Fixes #

To test:

Me > My Profile > Update Profile Photo

Regression Notes

  1. Potential unintended areas of impact

Avatars URLs. In fact, nothing has changed about Avatar URLs but let's just be extra careful for unexpected regressions.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Smoke test avatars throughout the app.

  1. What automated tests I added (or what prevented me from doing so)
    1 unit test added. 1 updated.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@pinarol pinarol added this to the 25.6 milestone Oct 25, 2024
@pinarol pinarol self-assigned this Oct 25, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 25, 2024

1 Warning
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 25, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23701-b225a2e
Version25.4.1
Bundle IDorg.wordpress.alpha
Commitb225a2e
App Center BuildWPiOS - One-Offs #10873
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 25, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23701-b225a2e
Version25.4.1
Bundle IDcom.jetpack.alpha
Commitb225a2e
App Center Buildjetpack-installable-builds #9914
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@pinarol pinarol requested a review from etoledom October 28, 2024 08:15
@pinarol pinarol added Gravatar Gravatar SDK related updates [Type] Enhancement labels Oct 28, 2024
@pinarol pinarol marked this pull request as ready for review October 28, 2024 08:21
@pinarol
Copy link
Contributor Author

pinarol commented Oct 28, 2024

About the dangermattic warning. I ran swift package resolve under /Modules. However, Modules/Package.swift is in .gitignore so not sure how to address that at the moment. 🤔 I will ask around. .

Edit: It turns out this is a false positive and the check will be removed.

@pinarol
Copy link
Contributor Author

pinarol commented Oct 28, 2024

This is ready to review.

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@pinarol pinarol added this pull request to the merge queue Oct 30, 2024
Merged via the queue into trunk with commit ecbf1d4 Oct 30, 2024
24 checks passed
@pinarol pinarol deleted the task/bump-up-gravatar-to-3.0.0 branch October 30, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gravatar Gravatar SDK related updates [Type] Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants