Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Oct 25, 2024

  • Remove the .readerReset FF and the deprecated code.
  • Remove duplicated actions from ReaderPostMenu (they are accessible from the cell itself)
  • Update UI tests

The only commits worth reviewing are the last two.

To test: n/a

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Oct 25, 2024
@kean kean added this to the 25.5 milestone Oct 25, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 25, 2024

3 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 25, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23704-e67611a
Version25.4.1
Bundle IDorg.wordpress.alpha
Commite67611a
App Center BuildWPiOS - One-Offs #10906
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Oct 25, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23704-e67611a
Version25.4.1
Bundle IDcom.jetpack.alpha
Commite67611a
App Center Buildjetpack-installable-builds #9946
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean marked this pull request as ready for review October 28, 2024 14:24
@kean kean requested a review from crazytonyli October 28, 2024 14:24
@crazytonyli
Copy link
Contributor

Is this PR supposed to target the trunk branch?

@kean
Copy link
Contributor Author

kean commented Oct 28, 2024

Is this PR supposed to target the trunk branch?

I haven't merged the new Reader PRs in trunk yet, but ultimately, yes. I think it's shippable with a couple of minor exceptions that I plan to cover tomorrow: cross-posts and some minor layout tweaks on iPad.

@crazytonyli
Copy link
Contributor

@kean Can you have a look at these two PRs to clear ways for this PR to be merged?

@kean kean force-pushed the task/reader-misc-improvements branch from a1a6fa9 to c2d273d Compare October 30, 2024 01:03
Base automatically changed from task/reader-misc-improvements to trunk October 30, 2024 11:37
@kean kean force-pushed the task/reader-code-removal branch from cc7d242 to 630721f Compare October 30, 2024 12:15
@kean
Copy link
Contributor Author

kean commented Oct 30, 2024

This PR is ready to be merged now, @crazytonyli .

@kean kean added this pull request to the merge queue Oct 30, 2024
Merged via the queue into trunk with commit cc4fad1 Oct 30, 2024
24 checks passed
@kean kean deleted the task/reader-code-removal branch October 30, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants