-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix bar chart colors #23712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bar chart colors #23712
Conversation
| static let brand = CSColor.WordPressBlue.base | ||
|
|
||
| static func brand(_ shade: ColorStudioShade) -> UIColor { | ||
| CSColor.WordPressBlue.shade(shade) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bit of a mess with this naming, and it might be worth refining it later.
brandis a confusing name because A8C has multiple brands and wpios sometimes uses Jetpack brand colorsWordPressBlueis a confusing name because it's actually "WordPress.Com Blue"primaryis a confusing name because in SwiftUIColor.primarytypically means primary text color (black/white)tintis a confusing name because jpios sometimes uses.labeland sometimes uses Jetpack green as a tint color
I don't have suggestions how to solve it because a lot of this complexity isn't incidental.
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23712-30056b6 | |
| Version | 25.4.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 30056b6 | |
| App Center Build | WPiOS - One-Offs #10878 |
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23712-30056b6 | |
| Version | 25.4.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 30056b6 | |
| App Center Build | jetpack-installable-builds #9919 |
| CSColor.WordPressBlue.shade(shade) | ||
| } | ||
|
|
||
| static let primary = CSColor.Blue.base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested every single place where these are used, but there are a bit obscure parts, and the logic seems sound as it's simply revert to the previous behavior.


Fixes #23709
RCA
In one of the previous releases,
func primarywas moved toUIColorwithout implementing a Jetpack-specific variant.In the previous versions, these would map to:
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: