Skip to content

Remove unnecessary trys #23723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024
+8 −10
Merged

Remove unnecessary trys #23723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions WordPress/WordPressTest/Blog Dashboard/Cards/DashboardBloganuaryCardCellTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,12 @@ final class DashboardBloganuaryCardCellTests: CoreDataTestCase {

override func setUp() {
super.setUp()
try? featureFlags.override(RemoteFeatureFlag.bloganuaryDashboardNudge, withValue: true)
featureFlags.override(RemoteFeatureFlag.bloganuaryDashboardNudge, withValue: true)
}

override func tearDown() {
super.tearDown()
try? featureFlags.override(RemoteFeatureFlag.bloganuaryDashboardNudge,
withValue: RemoteFeatureFlag.bloganuaryDashboardNudge.defaultValue)
featureFlags.override(RemoteFeatureFlag.bloganuaryDashboardNudge, withValue: RemoteFeatureFlag.bloganuaryDashboardNudge.defaultValue)
}

// MARK: - `shouldShowCard` tests
Expand All @@ -27,7 +26,7 @@ final class DashboardBloganuaryCardCellTests: CoreDataTestCase {
let blog = makeBlog()
makeBloggingPromptSettings()
try mainContext.save()
try featureFlags.override(RemoteFeatureFlag.bloganuaryDashboardNudge, withValue: false)
featureFlags.override(RemoteFeatureFlag.bloganuaryDashboardNudge, withValue: false)

// When
let result = DashboardBloganuaryCardCell.shouldShowCard(for: blog, date: sometimeInDecember)
Expand Down
7 changes: 3 additions & 4 deletions WordPress/WordPressTest/Blog Dashboard/Cards/DashboardJetpackSocialCardCellTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,13 @@ class DashboardJetpackSocialCardCellTests: CoreDataTestCase {
override func setUp() {
super.setUp()

try? featureFlags.override(RemoteFeatureFlag.jetpackSocialImprovements, withValue: true)
featureFlags.override(RemoteFeatureFlag.jetpackSocialImprovements, withValue: true)
}

override func tearDown() {
super.tearDown()

try? featureFlags.override(RemoteFeatureFlag.jetpackSocialImprovements,
withValue: RemoteFeatureFlag.jetpackSocialImprovements.defaultValue)
featureFlags.override(RemoteFeatureFlag.jetpackSocialImprovements, withValue: RemoteFeatureFlag.jetpackSocialImprovements.defaultValue)
}

// MARK: - `shouldShowCard` tests
Expand All @@ -33,7 +32,7 @@ class DashboardJetpackSocialCardCellTests: CoreDataTestCase {
let blog = createTestBlog()

// When
try featureFlags.override(RemoteFeatureFlag.jetpackSocialImprovements, withValue: false)
featureFlags.override(RemoteFeatureFlag.jetpackSocialImprovements, withValue: false)

// Then
XCTAssertFalse(shouldShowCard(for: blog))
Expand Down
4 changes: 2 additions & 2 deletions WordPress/WordPressTest/ReminderScheduleCoordinatorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ class ReminderScheduleCoordinatorTests: CoreDataTestCase {
private extension ReminderScheduleCoordinatorTests {

func disableBloggingPrompts() {
try! flagOverrideStore.override(FeatureFlag.bloggingPrompts, withValue: false)
flagOverrideStore.override(FeatureFlag.bloggingPrompts, withValue: false)
}

func enableBloggingPrompts(with behavior: MockSchedulerBehavior) {
try! flagOverrideStore.override(FeatureFlag.bloggingPrompts, withValue: true)
flagOverrideStore.override(FeatureFlag.bloggingPrompts, withValue: true)
let (hour, minute) = behavior.timeComponents
makePromptSettings(enabled: true, schedule: behavior.scheduleToReturn, hour: hour, minute: minute)
}
Expand Down