-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: Enable sharing to non-Jetpack sites #23778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Jetpack app is no longer positioned to be a product focused solely on Jetpack sites. Therefore, when sharing content to the Jetpack app, we should allow sharing content to non-Jetpack sites.
Collaborator
Generated by 🚫 Danger |
This release note was previously overlooked.
dcalhoun
commented
Nov 6, 2024
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23778-e1a3980 | |
| Version | 25.4.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e1a3980 | |
| App Center Build | WPiOS - One-Offs #11005 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23778-e1a3980 | |
| Version | 25.4.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e1a3980 | |
| App Center Build | jetpack-installable-builds #10045 |
kean
approved these changes
Nov 6, 2024
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value no longer diverges between the WordPress and Jetpack targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




The Jetpack app is no longer positioned to be a product focused solely on Jetpack sites. Therefore, when sharing content to the Jetpack app, we should allow sharing content to non-Jetpack sites.
Filtering the Jetpack app to include only Jetpack sites was done intentionally in #16140. The filtering was reverted in #17914, but the changes overlooked the sharing extension.
Fixes #23707.
To test: Perform the steps outlined in #23707.
Regression Notes
Sharing features.
Manually tested sharing content to the Jetpack app.
Deemed it unnecessary for this small change reverting a previously intentional
change.
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: