Skip to content

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Nov 6, 2024

The Jetpack app is no longer positioned to be a product focused solely on Jetpack sites. Therefore, when sharing content to the Jetpack app, we should allow sharing content to non-Jetpack sites.

Filtering the Jetpack app to include only Jetpack sites was done intentionally in #16140. The filtering was reverted in #17914, but the changes overlooked the sharing extension.

Fixes #23707.

To test: Perform the steps outlined in #23707.

Regression Notes

  1. Potential unintended areas of impact
    Sharing features.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested sharing content to the Jetpack app.
  3. What automated tests I added (or what prevented me from doing so)
    Deemed it unnecessary for this small change reverting a previously intentional
    change.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

The Jetpack app is no longer positioned to be a product focused solely
on Jetpack sites. Therefore, when sharing content to the Jetpack app, we
should allow sharing content to non-Jetpack sites.
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 6, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@dcalhoun dcalhoun marked this pull request as ready for review November 6, 2024 14:12
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 6, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23778-e1a3980
Version25.4.2
Bundle IDorg.wordpress.alpha
Commite1a3980
App Center BuildWPiOS - One-Offs #11005
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 6, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23778-e1a3980
Version25.4.2
Bundle IDcom.jetpack.alpha
Commite1a3980
App Center Buildjetpack-installable-builds #10045
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun requested a review from kean November 6, 2024 14:36
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes, and they work as expected. Great catch – one less paper cut.

Screenshot 2024-11-06 at 1 06 56 PM Screenshot 2024-11-06 at 1 10 50 PM

I'm still not sure under what circumstances you'd want to see only self-hosted sites connected to Jetpack but not the wp.com sites, but that's now irrelevant.

@dcalhoun dcalhoun requested a review from kean November 6, 2024 19:17
@dcalhoun dcalhoun added this pull request to the merge queue Nov 6, 2024
Merged via the queue into trunk with commit 5b97973 Nov 6, 2024
24 checks passed
@dcalhoun dcalhoun deleted the feat/enable-sharing-to-non-jetpack-sites branch November 6, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dotCom sites are not appearing in the Share Sheet

5 participants