Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Nov 6, 2024

  • On iPhone, show the "Logged Out" screen when opening Reader
  • On iPad, hide the "Reader", "Domains", and "Notifications" buttons
  • Align the chevrons in the Reader menu on iPhone
  • Fix an issue with Reader selection preserved after logout

To test:

  • Open the Jetpack app
  • Add a self-hosted site (do not login with a wp.com account)

Text inspired by the same on wp.com:

Screenshot 2024-11-06 at 5 13 42 PM
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-06.at.17.16.17.mp4
Screenshot 2024-11-06 at 6 18 35 PM

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Nov 6, 2024
@kean kean added this to the 25.5 milestone Nov 6, 2024
@kean kean requested a review from crazytonyli November 6, 2024 23:24
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 6, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger


view.backgroundColor = .systemBackground

let stateView = UIHostingView(view: EmptyStateView {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not using UIHostingViewController, which may require less set up code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason is this:

Button(Strings.signIn) { [weak self] in
    self?.buttonSignInTapped()
}.buttonStyle(.primary)

Task {
            await WordPressDotComAuthenticator().signIn(from: self, context: .default)
        }

I needed a reference to the containing UIViewController to have something I could start the login from. There are other ways to workaround this, but I found this to be the least worst.

@kean kean enabled auto-merge November 7, 2024 15:24
@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23781-63bd2f6
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit63bd2f6
App Center BuildWPiOS - One-Offs #11008
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23781-63bd2f6
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit63bd2f6
App Center Buildjetpack-installable-builds #10048
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added this pull request to the merge queue Nov 7, 2024
Merged via the queue into trunk with commit 67d9464 Nov 7, 2024
24 checks passed
@kean kean deleted the fix/logged-out-experience branch November 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants