-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Reader: Logged-out experience #23781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| view.backgroundColor = .systemBackground | ||
|
|
||
| let stateView = UIHostingView(view: EmptyStateView { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not using UIHostingViewController, which may require less set up code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason is this:
Button(Strings.signIn) { [weak self] in
self?.buttonSignInTapped()
}.buttonStyle(.primary)
Task {
await WordPressDotComAuthenticator().signIn(from: self, context: .default)
}I needed a reference to the containing UIViewController to have something I could start the login from. There are other ways to workaround this, but I found this to be the least worst.
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23781-63bd2f6 | |
| Version | 25.4.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 63bd2f6 | |
| App Center Build | WPiOS - One-Offs #11008 |
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23781-63bd2f6 | |
| Version | 25.4.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 63bd2f6 | |
| App Center Build | jetpack-installable-builds #10048 |


To test:
Text inspired by the same on wp.com:
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-06.at.17.16.17.mp4
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: