Reader: Fix "Select Interests" Flow

[kean]

This PR contains a couple of fixes to the "Select Interest" flow in the "Discover" tab.

• Fix Interest picker screen: change size of done button on iPad #14893 by showing the "Select Interests" in a modal screen
• Fixes scroll to top that now takes the safe area insets in to account
• Fix an issue with EmptyStateView covering the header and making it impossible to click anything in it
• Fix an issue with “Discover” showing “Failed to load content” when no interests are selected. If nothing is selected, the app will now load the same default tags as the web: dailyprompt, wordpress. This applies to the scenario where you manually remove all interests (tags) after selecting them.
• Fix an issue with Reader not hiding the sidebar on selection when in portrait (missing hideSupplementaryColumnIfNeeded call)
• Make sure that the "Select Interests" prompt is shown only once.
• Remove ReaderSearchSuggestionService that I forgot to remove earlier
• Update ReaderSelectInterestsViewController to be created lazily

Here's how the first-time user experience looks on iPad now:

Simulator.Screen.Recording.-.iPad.10th.generation.-.2024-11-07.at.17.58.36.mp4

To test:

Test 1

• Create a new account
• Open "Reader"
• Open "Discover"
• Verify that the "Select Interests" modal is shown and you can't dismiss it until you select at least one tag
• Select a couple of tags
• Verify that the modal is dismissed and the "Recommended" channel is reloaded
• Open "Interests" from the "Discover" header
• Remove all interests and save
• Verify that the default feed is shown (should show something)

Test 2

• Login with the existing account
• Open "Reader" / "Discover"
• Verify that the app doesn't ask you to select interests again

Known Issues

If you have an exiting account, there may be an a race condition when loading interest remotely and showing "Select Interest". I haven't reproduced it yet, and I haven't change the logic, but it is there.

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 25.5. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23784-2825e28
	Version	25.4.2
	Bundle ID	org.wordpress.alpha
	Commit	2825e28
	App Center Build	WPiOS - One-Offs #11012

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23784-2825e28
	Version	25.4.2
	Bundle ID	com.jetpack.alpha
	Commit	2825e28
	App Center Build	jetpack-installable-builds #10052

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.