Skip to content

Present an alert for setting a new password #23790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

Present an alert for setting a new password #23790

merged 2 commits into from
Nov 13, 2024

Conversation

@crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Nov 10, 2024

Note

This PR is built on top of #23777.

Changing from pushing a separate page to presenting an alert.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.6 milestone Nov 10, 2024
@crazytonyli crazytonyli requested a review from kean November 10, 2024 23:44
@crazytonyli crazytonyli mentioned this pull request Nov 10, 2024
Merged
14 tasks
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 10, 2024 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23790-23b68b9
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit23b68b9
App Center Buildjetpack-installable-builds #10077
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 10, 2024 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23790-23b68b9
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit23b68b9
App Center BuildWPiOS - One-Offs #11038
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

kean
kean approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@kean kean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with two minor comments.

Modules/Sources/WordPressUI/Views/Users/Views/UserDetailsView.swift
presentPasswordAlert = false
} label: {
// TODO: Replace with `SharedStrings.Button.cancel`
Text(NSLocalizedString("shared.button.cancel", value: "Cancel", comment: "A shared button title used in different contexts"))
Copy link
Contributor

@kean kean Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would've probably been faster to do it that to add a TODO :laugh

Copy link
Contributor Author

@crazytonyli crazytonyli Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to move all the "Users" code to the app target first 🥲

Copy link
Contributor

@kean kean Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Yeah, I'd suggest moving it until there is an idea of how to organize it better.

Modules/Sources/WordPressUI/Views/Users/Views/UserDetailsView.swift Outdated
func makeBody(configuration: LabeledContentStyleConfiguration) -> some View {
LabeledContent(configuration)
static let newPasswordAlertMessage = NSLocalizedString(
"userdetail.newPasswordAlertMessage",
Copy link
Contributor

@kean kean Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be userDetails.*

Base automatically changed from fix/self-hosted-site-users to trunk November 13, 2024 22:08
@crazytonyli crazytonyli force-pushed the fix/self-hosted-site-user-set-new-password branch from 4b65083 to c2e4558 Compare November 13, 2024 22:16
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 13, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.6. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@crazytonyli crazytonyli added this pull request to the merge queue Nov 13, 2024
Merged via the queue into trunk with commit 1898814 Nov 13, 2024
24 checks passed
@crazytonyli crazytonyli deleted the fix/self-hosted-site-user-set-new-password branch November 13, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kean kean kean approved these changes

Assignees

No one assigned

Labels

Self-hosted

Projects

None yet

Milestone

25.6

Development

Successfully merging this pull request may close these issues.

5 participants

@crazytonyli @wpmobilebot @dangermattic @kean